You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2021/03/29 19:59:57 UTC

Review Request 73259: RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73259/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Repository: ranger


Description
-------

RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 906ff341f 


Diff: https://reviews.apache.org/r/73259/diff/1/


Testing
-------

- Verified in S3 and hdfs audit destination.


Thanks,

Ramesh Mani

Re: Review Request 73259: RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73259/#review222740
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 30, 2021, 7:17 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73259/
> -----------------------------------------------------------
> 
> (Updated March 30, 2021, 7:17 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 906ff341f 
> 
> 
> Diff: https://reviews.apache.org/r/73259/diff/3/
> 
> 
> Testing
> -------
> 
> - Verified in S3 and hdfs audit destination.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 73259: RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73259/
-----------------------------------------------------------

(Updated March 30, 2021, 7:17 a.m.)


Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Fixed review comments


Repository: ranger


Description
-------

RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api


Diffs (updated)
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 906ff341f 


Diff: https://reviews.apache.org/r/73259/diff/3/

Changes: https://reviews.apache.org/r/73259/diff/2-3/


Testing
-------

- Verified in S3 and hdfs audit destination.


Thanks,

Ramesh Mani

Re: Review Request 73259: RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73259/#review222739
-----------------------------------------------------------


Fix it, then Ship it!





agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java
Lines 313 (patched)
<https://reviews.apache.org/r/73259/#comment311899>

    - isSyncableChecked - is this necessary? If ostream.hasCapability() is not expensive, it will be simple to assign isSyncableStream on every fileSystem.create() above.
    - isSyncableStream => isHFlushCapableStream


- Madhan Neethiraj


On March 30, 2021, 12:32 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73259/
> -----------------------------------------------------------
> 
> (Updated March 30, 2021, 12:32 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 906ff341f 
> 
> 
> Diff: https://reviews.apache.org/r/73259/diff/2/
> 
> 
> Testing
> -------
> 
> - Verified in S3 and hdfs audit destination.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 73259: RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73259/
-----------------------------------------------------------

(Updated March 30, 2021, 12:32 a.m.)


Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Updated patch


Repository: ranger


Description
-------

RANGER-3226:Ranger Audit framework to handle UnsupportedOperationException while writing into S3AFileSystem with hflush api


Diffs (updated)
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 906ff341f 


Diff: https://reviews.apache.org/r/73259/diff/2/

Changes: https://reviews.apache.org/r/73259/diff/1-2/


Testing
-------

- Verified in S3 and hdfs audit destination.


Thanks,

Ramesh Mani