You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Max Gekk (Jira)" <ji...@apache.org> on 2022/10/13 11:12:00 UTC

[jira] [Updated] (SPARK-40784) Check error classes in DDLParserSuite

     [ https://issues.apache.org/jira/browse/SPARK-40784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Gekk updated SPARK-40784:
-----------------------------
    Description: 
Check error classes in DDLParserSuite by using checkError(). For instance, replace

{code:scala}
intercept("CREATE TABLE my_tab (id bigint) SKEWED BY (id) ON (1,2,3)",
      "CREATE TABLE ... SKEWED BY")
{code}
by
{code:scala}
checkError(
      exception = parseException("CREATE TABLE my_tab (id bigint) SKEWED BY (id) ON (1,2,3)"),
      errorClass = "...",
      parameters = Map.empty,
      context = ...)
{code}
at https://github.com/apache/spark/blob/1a1341910249d545365ba3d6679c6943896dde22/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala#L546



  was:
Check error classes in ErrorParserSuite by using checkError(). For instance, replace

{code:scala}
intercept("select *\nfrom r\norder by q\ncluster by q", 3, 0, 11,
      "Combination of ORDER BY/SORT BY/DISTRIBUTE BY/CLUSTER BY is not supported",
      "^^^")
{code}
by
{code:scala}
checkError(
      exception = parseException("select *\nfrom r\norder by q\ncluster by q"),
      errorClass = "_LEGACY_ERROR_TEMP_0011",
      parameters = Map.empty,
      context = ExpectedContext(fragment = "order by q\ncluster by q", start = 16, stop = 38))
{code}
at https://github.com/apache/spark/blob/96ed6dc3e38b22b4aefc41e20ba7c953f8f2251e/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ErrorParserSuite.scala#L79-L83




> Check error classes in DDLParserSuite
> -------------------------------------
>
>                 Key: SPARK-40784
>                 URL: https://issues.apache.org/jira/browse/SPARK-40784
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 3.4.0
>            Reporter: Max Gekk
>            Assignee: Max Gekk
>            Priority: Major
>             Fix For: 3.4.0
>
>
> Check error classes in DDLParserSuite by using checkError(). For instance, replace
> {code:scala}
> intercept("CREATE TABLE my_tab (id bigint) SKEWED BY (id) ON (1,2,3)",
>       "CREATE TABLE ... SKEWED BY")
> {code}
> by
> {code:scala}
> checkError(
>       exception = parseException("CREATE TABLE my_tab (id bigint) SKEWED BY (id) ON (1,2,3)"),
>       errorClass = "...",
>       parameters = Map.empty,
>       context = ...)
> {code}
> at https://github.com/apache/spark/blob/1a1341910249d545365ba3d6679c6943896dde22/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala#L546



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org