[jira] [Comment Edited] (CASSANDRA-6253) Refactor: remove CFDefinition

["Dave Brosius (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811038#comment-13811038 ] 

Dave Brosius edited comment on CASSANDRA-6253 at 11/1/13 4:40 AM:
------------------------------------------------------------------

ColumnDefinition.name was switched from a ByteBuffer to a ColumnIdentifier, but comparisons remain that treat it like a ByteBuffer. Update comparisons to get the underlying ByteBuffer to compare.

patch 0003-Fix-CFDefinition.name-comparisons.txt


was (Author: dbrosius):
ColumnDefinition.name was switched from a ByteBuffer to a ColumnIdentifier, but comparisons remain that treat it like a ByteBuffer. Update comparisons to get the underlying ByteBuffer to compare.

> Refactor: remove CFDefinition
> -----------------------------
>
>                 Key: CASSANDRA-6253
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6253
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 2.1
>
>         Attachments: 0001-Remove-CFDefinition.txt, 0002-Unit-tests-updates.txt, 0003-Fix-CFDefinition.name-comparisons.txt
>
>
> While writing CQL3 initially, we added CFDefinition to be a CQL3-friendly version of CFMetaData. However, a number of changes have it redundant. The infos of CFDefinition are now in CFMetaData in pretty much the same form and in particular CFDefinition.Name is now basically a copy of ColumnDefinition.  This is not only useless, but it is confusing too: sometimes the CQL3 code uses ColumnDefinition because it has too, but more often it uses CFDefinition.Name and both use diferent vocabulary even though they are the exact same thing.
> So this ticket propose to remove CFDefinition and CFDefinition.Name since they are not useful anymore and this clean things up.



--
This message was sent by Atlassian JIRA
(v6.1#6144)