[jira] [Commented] (ASTERIXDB-2610) Improve deep comparison runtime

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ASTERIXDB-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887474#comment-16887474 ] 

ASF subversion and git services commented on ASTERIXDB-2610:
------------------------------------------------------------

Commit ddff76e4cf2da02d4100555d228371958d76dbc2 in asterixdb's branch refs/heads/master from Ali Alsuliman
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=ddff76e ]

[ASTERIXDB-2610][RT][*DB] Improve deep comparison runtime

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
Avoid data copies during comparison (no visitable pointables).
Allow comparison of non-tagged values to avoid copying the tag
when accessing an array element or record field.

- added TaggedValueReference.
- changed ILogicalBinaryComparator to use TaggedValueReference
	instead of IPointable.
- removed numberOfItems() from ListAccessorUtil and used
	AOrderedListSerializerDeserializer.getNumberOfItems().
- removed storage & IPointable pools from AbstractAGenericBinaryComparator
	& LogicalComplexBinaryComparator and used TaggedValueReference pool.
- removed compareNumbers() from ComparatorUtil since IPointable's
	have been replaced with TaggedValueReference.
- adapted record comparison logic in LogicalComplexBinaryComparator
	to match the logic in the physical comparator.

Change-Id: Id9ece93c704f566d7bdb7fd17b1ba92713c917d5
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3466
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ali Alsuliman <al...@gmail.com>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
Reviewed-by: Till Westmann <ti...@apache.org>


> Improve deep comparison runtime
> -------------------------------
>
>                 Key: ASTERIXDB-2610
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2610
>             Project: Apache AsterixDB
>          Issue Type: Bug
>          Components: *DB - AsterixDB, RT - Runtime
>    Affects Versions: 0.9.5
>            Reporter: Ali Alsuliman
>            Assignee: Ali Alsuliman
>            Priority: Major
>             Fix For: 0.9.5
>
>
> * avoid data copies during comparison/hashing (no visitable pointables)
>  * allow comparison of non-tagged values to avoid copying the tag when accessing an array element or record field.
>  * allow hashing of non-tagged values to avoid copying the tag when accessing an array element or record field.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)