You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/12/15 11:41:10 UTC

Review Request 64646: Unified return type of `wait`, `destroy`, `kill` containerizer methods.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64646/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.


Repository: mesos


Description
-------

This change refactors `wait()`, `destroy()` and `kill()` methods of
Containerizer base class as well as MesosContainerizer,
DockerContainerizer and ComposingContainerizer in order to return the
same ContainerTermination type. In fact, all these methods depend on
the same container termination promise, so this unification makes both
containerizer interface and internal logic more consistent.


Diffs
-----

  src/slave/containerizer/composing.hpp 1221d9b61b7cfbdbaa560dbafb0158225331ed6d 
  src/slave/containerizer/composing.cpp 9ace70d9fbd78182715c5ef13fcaf7ad45f76f97 
  src/slave/containerizer/containerizer.hpp 836283aa8aa827459558d567e090a230c32351ed 
  src/slave/containerizer/docker.hpp f1b56c8edced17e9786c86adb9b92c829ed81635 
  src/slave/containerizer/docker.cpp 890cb2aba44fe76e891117833eac8ccca00b759b 
  src/slave/containerizer/mesos/containerizer.hpp 965e183bb5c54f31d90e910edd35313ab380cea9 
  src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365 
  src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 


Diff: https://reviews.apache.org/r/64646/diff/1/


Testing
-------

make check (fedora 25)
internal CI


Thanks,

Andrei Budnik