You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/03/25 16:33:29 UTC

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337 

Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12844


Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................

IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Fixes in IMPALA-8317 and IMPALA-8337 introduced third-party dependencies
in Impala shell which is problematic in multi-Python environment. This
patch rewrites the fixes using an alternative solution when dealing with
duplicate options without any third-party dependencies. For example:

[impala]
keyval=msg1=hello,keyval=msg2=world

Testing:
- Ran all shell tests on Python 2.6 and 2.7.

Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
---
M infra/python/deps/requirements.txt
M shell/option_parser.py
M tests/shell/good_impalarc
3 files changed, 8 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/12844/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................

IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Fixes in IMPALA-8317 and IMPALA-8337 introduced third-party dependencies
in Impala shell which is problematic in multi-Python environment. This
patch rewrites the fixes using an alternative solution when dealing with
duplicate options without any third-party dependencies. For example:

[impala]
keyval=msg1=hello,keyval=msg2=world

Testing:
- Ran all shell tests on Python 2.6 and 2.7.
- Ran make_shell_tarball.sh and ran Impala shell from the tarball
  without any issue.

Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Reviewed-on: http://gerrit.cloudera.org:8080/12844
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M infra/python/deps/requirements.txt
M shell/option_parser.py
M tests/shell/good_impalarc
3 files changed, 8 insertions(+), 28 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2532/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:22:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 4:

> Patch Set 4: Code-Review+2
> 
> Hmm, my understanding was that we would not need duplicate keys if var would get its own config group. 
> impala-shell --var=msg1=hello --var=msg2=hello
> could be expressed by:
> [impala.var]
> msg1=hello
> msg2=world

Ah, I see what you mean.


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 23:11:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................

IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Fixes in IMPALA-8317 and IMPALA-8337 introduced third-party dependencies
in Impala shell which is problematic in multi-Python environment. This
patch rewrites the fixes using an alternative solution when dealing with
duplicate options without any third-party dependencies. For example:

[impala]
keyval=msg1=hello,keyval=msg2=world

Testing:
- Ran all shell tests on Python 2.6 and 2.7.
- Ran make_shell_tarball.sh and ran Impala shell from the tarball
  without any issue.

Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
---
M infra/python/deps/requirements.txt
M shell/option_parser.py
M tests/shell/good_impalarc
3 files changed, 8 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/12844/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 4: Code-Review+2

Hmm, my understanding was that we would not need duplicate keys if var would get its own config group. 
impala-shell --var=msg1=hello --var=msg2=hello
could be expressed by:
[impala.var]
msg1=hello
msg2=world


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 22:29:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2534/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:31:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................

IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Fixes in IMPALA-8317 and IMPALA-8337 introduced third-party dependencies
in Impala shell which is problematic in multi-Python environment. This
patch rewrites the fixes using an alternative solution when dealing with
duplicate options without any third-party dependencies. For example:

[impala]
keyval=msg1=hello,keyval=msg2=world

Testing:
- Ran all shell tests on Python 2.6 and 2.7.
- Ran make_shell_tarball.sh and ran Impala shell from the tarball
  without any issue.

Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
---
M infra/python/deps/requirements.txt
M shell/option_parser.py
M tests/shell/good_impalarc
3 files changed, 8 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/12844/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 23:11:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Mar 2019 04:03:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3954/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 23:11:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12844/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12844/4//COMMIT_MSG@14
PS4, Line 14: [impala]
            : keyval=msg1=hello,keyval=msg2=world
> An alternative approach to options with multiple key/value pairs is to trea
I don't think the implementation in [impala.query_options] supports duplicate keys. For example:

[impala.query_options]
EXPLAIN_LEVEL=1
explain_LEVEL=2

The code will take the second explain_level and not both. It gets trickier too if we ever support a new flag that has "action=append", then we will always have to support a new section in the config file.

The reason why we supported duplicate keys in the earlier patch is for this particular use case.

impala-shell --var=msg1=hello --var=msg2=hello

[impala]
var=msg1=hello
var=msg2=world

It would be much nicer for the user experience, however it comes with its own set of problems too :(



-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 18:18:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2530/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:12:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12844/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12844/4//COMMIT_MSG@14
PS4, Line 14: [impala]
            : keyval=msg1=hello,keyval=msg2=world
An alternative approach to options with multiple key/value pairs is to treat them as separate config group like query_options, see https://gerrit.cloudera.org/#/c/8038/

I do not want to force it on you, but I think that it results in easier to read impala.rc files and would be consistent with the way query options works. Its drawback is that its implementation is more complex, so it may be a bad direction if we want to add several list type options.

(I should have mentioned this in the original review, https://gerrit.cloudera.org/#/c/12781, but I did not have time to look at it. )



-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:20:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )

Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 21:12:42 +0000
Gerrit-HasComments: No