You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/29 06:04:42 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2714: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]
Alonexc opened a new issue, #2714:
URL: https://github.com/apache/incubator-eventmesh/issues/2714
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer/HttpClientGroupMapping.java line 309,314
analysis and explanation:
This method calls the size() method on a collection and compares the result to zero to see if the collection is empty.
### Describe the solution you'd like
For better code clarity, it is better to just use col.isEmpty().
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #2714: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #2714:
URL: https://github.com/apache/incubator-eventmesh/issues/2714#issuecomment-1373017026
> No size()method is present at line 309,314
Due to code updates, it may be different from the actual location, which is now at lines 362 and 369.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed issue #2714: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]
Posted by GitBox <gi...@apache.org>.
jonyangx closed issue #2714: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]
URL: https://github.com/apache/incubator-eventmesh/issues/2714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] tarunsamanta2k20 commented on issue #2714: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]
Posted by GitBox <gi...@apache.org>.
tarunsamanta2k20 commented on issue #2714:
URL: https://github.com/apache/incubator-eventmesh/issues/2714#issuecomment-1373480090
@Alonexc
I will do it by eod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] tarunsamanta2k20 commented on issue #2714: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]
Posted by GitBox <gi...@apache.org>.
tarunsamanta2k20 commented on issue #2714:
URL: https://github.com/apache/incubator-eventmesh/issues/2714#issuecomment-1367336047
I would like to work on this issue. Please assign it to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] tarunsamanta2k20 commented on issue #2714: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [HttpClientGroupMapping]
Posted by GitBox <gi...@apache.org>.
tarunsamanta2k20 commented on issue #2714:
URL: https://github.com/apache/incubator-eventmesh/issues/2714#issuecomment-1370998208
No size()method is present at line 309,314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org