[GitHub] [druid] vogievetsky commented on a change in pull request #10438: Web console: Display compaction status

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #10438:
URL: https://github.com/apache/druid/pull/10438#discussion_r496105362



##########
File path: web-console/src/components/json-input/json-input.tsx
##########
@@ -80,12 +80,11 @@ export const JsonInput = React.memo(function JsonInput(props: JsonInputProps) {
   const aceEditor = useRef<Editor | undefined>();
 
   useEffect(() => {
-    if (!deepEqual(value, internalValue.value)) {
-      setInternalValue({
-        value,
-        stringified: stringifyJson(value),
-      });
-    }
+    if (deepEqual(value, internalValue.value)) return;
+    setInternalValue({
+      value,
+      stringified: stringifyJson(value),
+    });

Review comment:
       there is no logical change here... just wanted to have less nesting




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org