You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/01/11 00:29:22 UTC
[GitHub] [fineract] vorburger opened a new pull request #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
vorburger opened a new pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685#issuecomment-573410732
> Which one are you merging first. This or #682 ?
#682 just merged, this one was actually just an extension with 1 more additional commit over that one. There's no real good way to do this better in GitHub (that I know of), so what I "imply" (but should say more clearly?) when I raise a PR like this one for review is to manually click on the last commit of such a PR (in the _Commits_ tab) in review that, instead of everything on the _Files changed_ tab (or use that Changes from drop down on _Files changed_ to review only last commit instead of _from all commits_).
> @vorburger thanks very much
You are the one to thank, this (that we've finally properly adopted SpotBugs here) is amazing!
If this small PR is OK with you, just go ahead and merge it (use _Rebase and merge_ to avoid the merge commit, because #684 is "parallel"). -- PS: I hope this doesn't fail in Integration Test again due to [FINERACT-820](https://issues.apache.org/jira/browse/FINERACT-820) - as it's Sunday... if it does, we really should figure out how to fix that problem.. or ask on list if anyone would like to take that on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger opened a new pull request #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
Posted by GitBox <gi...@apache.org>.
vorburger opened a new pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum merged pull request #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
Posted by GitBox <gi...@apache.org>.
awasum merged pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685#issuecomment-574044586
This looks good merging now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685#issuecomment-573414336
> PS: I hope this doesn't fail in Integration Test again due to [FINERACT-820](https://issues.apache.org/jira/browse/FINERACT-820) - as it's Sunday... if it does, we really should figure out how to fix that problem.. or ask on list if anyone would like to take that on.
It did, this is really annoying.. are you willing to just review and merge this ignoring that `LoanReschedulingWithinCenterTest` failure? Or motivated to investigate how that could be fixed properly once and for all? I'll drop an email to the list as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685#issuecomment-573294636
Which one are you merging first. This or #682 ?
@vorburger thanks very much for taking the time to review and augment the spotbug integration work. I am grateful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger closed pull request #685: clean up
GLAccountBuilder, following SpotBugs (FINERACT-702)
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services