You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/04/30 17:31:30 UTC
[GitHub] [incubator-brpc] guodongxiaren opened a new pull request, #1755: client.md 文档优化
guodongxiaren opened a new pull request, #1755:
URL: https://github.com/apache/incubator-brpc/pull/1755
https:// 后面补一个空格，防止后面的中文被网页识别成链接的一部分，引起误解（以为是引用了其他文档）。当前网页上显示效果如下：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #1755: client.md 文档优化
Posted by GitBox <gi...@apache.org>.
wwbmmm merged PR #1755:
URL: https://github.com/apache/incubator-brpc/pull/1755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on pull request #1755: client.md 文档优化
Posted by GitBox <gi...@apache.org>.
serverglen commented on PR #1755:
URL: https://github.com/apache/incubator-brpc/pull/1755#issuecomment-1114211126
文档要不直接提交到 apache/incubator-brpc-website
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on a diff in pull request #1755: client.md 文档优化
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on code in PR #1755:
URL: https://github.com/apache/incubator-brpc/pull/1755#discussion_r867471462
##########
docs/cn/client.md:
##########
@@ -731,7 +731,7 @@ options.mutable_ssl_options()->sni_name = "...";
```
- 连接单点和集群的Channel均可以开启SSL访问（初始实现曾不支持集群）。
- 开启后，该Channel上任何协议的请求，都会被SSL加密后发送。如果希望某些请求不加密，需要额外再创建一个Channel。
-- 针对HTTPS做了些易用性优化：Channel.Init能自动识别https://前缀并自动开启SSL；开启-http_verbose也会输出证书信息。
+- 针对HTTPS做了些易用性优化：Channel.Init能自动识别https:// 前缀并自动开启SSL；开启-http_verbose也会输出证书信息。
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wasphin commented on a diff in pull request #1755: client.md 文档优化
Posted by GitBox <gi...@apache.org>.
wasphin commented on code in PR #1755:
URL: https://github.com/apache/incubator-brpc/pull/1755#discussion_r865499124
##########
docs/cn/client.md:
##########
@@ -731,7 +731,7 @@ options.mutable_ssl_options()->sni_name = "...";
```
- 连接单点和集群的Channel均可以开启SSL访问（初始实现曾不支持集群）。
- 开启后，该Channel上任何协议的请求，都会被SSL加密后发送。如果希望某些请求不加密，需要额外再创建一个Channel。
-- 针对HTTPS做了些易用性优化：Channel.Init能自动识别https://前缀并自动开启SSL；开启-http_verbose也会输出证书信息。
+- 针对HTTPS做了些易用性优化：Channel.Init能自动识别https:// 前缀并自动开启SSL；开启-http_verbose也会输出证书信息。
Review Comment:
建议用行内代码块方式，如：`https://`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org