[GitHub] [tvm] leandron commented on a diff in pull request #14635: [CI] Upgrade CI

["leandron (via GitHub)" <gi...@apache.org>]

leandron commented on code in PR #14635:
URL: https://github.com/apache/tvm/pull/14635#discussion_r1183374514


##########
docker/install/ubuntu_install_ethosn_driver_stack.sh:
##########
@@ -54,4 +48,4 @@ cd "$tmpdir"
 git clone --branch "$repo_revision" "$repo_url" "$repo_dir"
 
 cd "$repo_dir"/driver
-scons install_prefix="$install_path" install
+scons werror=False install_prefix="$install_path" install

Review Comment:
   Do you mind opening an issue to report what is the error that makes this script now need `werror=False`?
   
   I understand it will have some output, but can you add that output in the issue, so that somebody can pick that up to investigate?



##########
docker/Dockerfile.ci_arm:
##########
@@ -53,10 +53,10 @@ ENV PATH /opt/sccache:$PATH
 COPY install/ubuntu_install_llvm_from_source.sh /install/ubuntu_install_llvm_from_source.sh
 RUN bash /install/ubuntu_install_llvm_from_source.sh 15.0.7 8b5fcb24b4128cf04df1b0b9410ce8b1a729cb3c544e6da885d234280dedeac6

Review Comment:
   Given we will be installing LLVM 15 from apt repositories, this can be removed in future. We don't need to block this PR, but can you open an issue so that we can actually do this in a follow-up PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org