You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by li...@apache.org on 2007/08/05 05:52:55 UTC
svn commit: r562815 -
/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
Author: linsun
Date: Sat Aug 4 20:52:54 2007
New Revision: 562815
URL: http://svn.apache.org/viewvc?view=rev&rev=562815
Log:
minor rework of GERONIMO-3378 - use log.debug(e.getMessage(), e); to log the trace
Modified:
geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
Modified: geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java?view=diff&rev=562815&r1=562814&r2=562815
==============================================================================
--- geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java (original)
+++ geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java Sat Aug 4 20:52:54 2007
@@ -159,8 +159,9 @@
environment.put(JMXConnector.CREDENTIALS, credentials);
environment.put(JMXConnectorFactory.DEFAULT_CLASS_LOADER, BaseDeploymentFactory.class.getClassLoader());
try {
- if (log.isDebugEnabled())
+ if (log.isDebugEnabled()) {
log.debug("Using JMXServiceURL with host=" + params.getHost() + ", port=" + params.getPort());
+ }
JMXServiceURL address = new JMXServiceURL("service:jmx:rmi:///jndi/rmi://"+params.getHost()+":"+params.getPort()+"/JMXConnector");
JMXConnector jmxConnector = JMXConnectorFactory.connect(address, environment);
RemoteDeploymentManager manager = getRemoteDeploymentManager();
@@ -170,16 +171,16 @@
}
return manager;
} catch (IOException e) {
- log.fatal("caught " + e);
- DeploymentManagerCreationException deploymentManagerCreationException = (DeploymentManagerCreationException) new DeploymentManagerCreationException(
- e.getMessage()).initCause(e);
- log.fatal("throwing " + deploymentManagerCreationException);
+ log.fatal("caught " + e.getMessage(), e);
+ DeploymentManagerCreationException deploymentManagerCreationException =
+ (DeploymentManagerCreationException) new DeploymentManagerCreationException(e.getMessage()).initCause(e);
+ log.fatal("throwing " + deploymentManagerCreationException.getMessage(), deploymentManagerCreationException);
throw deploymentManagerCreationException;
} catch (SecurityException e) {
- log.fatal("caught " + e);
- AuthenticationFailedException authenticationFailedException = (AuthenticationFailedException) new AuthenticationFailedException(
- "Invalid login.").initCause(e);
- log.fatal("throwing " + authenticationFailedException);
+ log.fatal("caught " + e.getMessage(), e);
+ AuthenticationFailedException authenticationFailedException =
+ (AuthenticationFailedException) new AuthenticationFailedException("Invalid login.").initCause(e);
+ log.fatal("throwing " + authenticationFailedException.getMessage(), authenticationFailedException);
throw authenticationFailedException;
}
}