You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/21 03:37:12 UTC
[GitHub] [incubator-hudi] wangxianghu opened a new pull request #1263:
[MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
wangxianghu opened a new pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263
## What is the purpose of the pull request
*Update the javadoc of HoodieTableMetaClient#scanFiles*
## Brief change log
*Update the javadoc of HoodieTableMetaClient#scanFiles*
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request
#1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#discussion_r368800615
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -381,7 +381,15 @@ public static HoodieTableMetaClient initTableAndGetMetaClient(Configuration hado
return metaClient;
}
- // HELPER METHODS TO CREATE META FILE NAMES
+ /**
+ * Helper methods to create meta file names.
Review comment:
@yanghua Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request
#1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#discussion_r368824428
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -381,7 +381,15 @@ public static HoodieTableMetaClient initTableAndGetMetaClient(Configuration hado
return metaClient;
}
- // HELPER METHODS TO CREATE META FILE NAMES
+ /**
+ * Helper methods to create meta file names.
Review comment:
@yanghua PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request
#1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#discussion_r368827950
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -381,7 +381,15 @@ public static HoodieTableMetaClient initTableAndGetMetaClient(Configuration hado
return metaClient;
}
- // HELPER METHODS TO CREATE META FILE NAMES
+ /**
+ * Helper method to scan all hoodie-instant metafiles.
+ *
+ * @param fs Fs implementation for this table
+ * @param metaPath MetaPath where meta files are stored
+ * @param nameFilter NameFilter to filter meta files
Review comment:
I'd suggest changing `Fs`, `MetaPath` and `NameFilter` to `The file system`, `The meta path` and `The name filter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua merged pull request #1263: [MINOR] Update
the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on issue #1263: [MINOR]
Update the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on issue #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#issuecomment-576540719
@yanghua OK, Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request
#1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#discussion_r368829172
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -381,7 +381,15 @@ public static HoodieTableMetaClient initTableAndGetMetaClient(Configuration hado
return metaClient;
}
- // HELPER METHODS TO CREATE META FILE NAMES
+ /**
+ * Helper method to scan all hoodie-instant metafiles.
+ *
+ * @param fs Fs implementation for this table
+ * @param metaPath MetaPath where meta files are stored
+ * @param nameFilter NameFilter to filter meta files
Review comment:
@yanghua，Thanks for your suggestion, I'll fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request
#1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#discussion_r368829172
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -381,7 +381,15 @@ public static HoodieTableMetaClient initTableAndGetMetaClient(Configuration hado
return metaClient;
}
- // HELPER METHODS TO CREATE META FILE NAMES
+ /**
+ * Helper method to scan all hoodie-instant metafiles.
+ *
+ * @param fs Fs implementation for this table
+ * @param metaPath MetaPath where meta files are stored
+ * @param nameFilter NameFilter to filter meta files
Review comment:
@yanghua，Thanks for your suggestion, I'll fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request
#1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#discussion_r368799864
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -381,7 +381,15 @@ public static HoodieTableMetaClient initTableAndGetMetaClient(Configuration hado
return metaClient;
}
- // HELPER METHODS TO CREATE META FILE NAMES
+ /**
+ * Helper methods to create meta file names.
Review comment:
`methods` -> `method`. IMO, the original comment is incorrect. You should correct the java doc based on the logic of this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services