You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by Jesse Yang <jy...@gmail.com> on 2020/11/24 05:54:04 UTC

[VOTE] SIP-56 Proposal to Adopt React Testing Library

Hi All,

I'm calling a vote for https://github.com/apache/incubator-superset/issues/11688 <https://github.com/apache/incubator-superset/issues/11688>

Here's an accompanying PR: https://github.com/apache/incubator-superset/pull/11771 <https://github.com/apache/incubator-superset/pull/11771> 


Thanks,
Jesse

Re: [VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Ville Brofeldt <vi...@gmail.com>.
+1 (binding)

Ville

> On 1. Dec 2020, at 20.31, Tai Dupree <ta...@apache.org> wrote:
> 
> *+1* (binding)
> 
> On Wed, Nov 25, 2020 at 3:08 PM Rob DiCiuccio <ro...@preset.io> wrote:
> 
>> I appreciate the additional insights provided in the Github issue, thanks
>> to all for the discussion.
>> 
>> +1 (binding) on moving forward with RTL on an evaluation basis
>> 
>> On Wed, Nov 25, 2020 at 10:47 AM Rob DiCiuccio <ro...@preset.io> wrote:
>> 
>>> I'd like to better understand what problems with the Enzyme testing flow
>>> we're trying to solve with this migration. The SIP states only that
>> Enzyme
>>> is "running behind in catching up with all the latest React trends" and
>>> "doesn’t support the useEffect hook" as rationale. I would argue that we
>>> should not be chasing the latest trends without a good reason to do so,
>> and
>>> while hooks are currently popular, we have not agreed on hooks as our
>>> accepted approach going forward.
>>> 
>>> Let's continue the discussion in the Github issue.
>>> 
>>> On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <jy...@gmail.com> wrote:
>>> 
>>>> Hi All,
>>>> 
>>>> I'm calling a vote for
>>>> https://github.com/apache/incubator-superset/issues/11688 <
>>>> https://github.com/apache/incubator-superset/issues/11688>
>>>> 
>>>> Here's an accompanying PR:
>>>> https://github.com/apache/incubator-superset/pull/11771 <
>>>> https://github.com/apache/incubator-superset/pull/11771>
>>>> 
>>>> 
>>>> Thanks,
>>>> Jesse
>>>> 
>>>> 
>>>> 
>>> 
>>> --
>>> 
>>> *Rob DiCiuccio* (he/him)
>>> Director of Engineering
>>> Preset | https://preset.io
>>> 
>> 
>> 
>> --
>> 
>> *Rob DiCiuccio* (he/him)
>> Director of Engineering
>> Preset | https://preset.io
>>

Re: [VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Tai Dupree <ta...@apache.org>.
*+1* (binding)

On Wed, Nov 25, 2020 at 3:08 PM Rob DiCiuccio <ro...@preset.io> wrote:

> I appreciate the additional insights provided in the Github issue, thanks
> to all for the discussion.
>
> +1 (binding) on moving forward with RTL on an evaluation basis
>
> On Wed, Nov 25, 2020 at 10:47 AM Rob DiCiuccio <ro...@preset.io> wrote:
>
> > I'd like to better understand what problems with the Enzyme testing flow
> > we're trying to solve with this migration. The SIP states only that
> Enzyme
> > is "running behind in catching up with all the latest React trends" and
> > "doesn’t support the useEffect hook" as rationale. I would argue that we
> > should not be chasing the latest trends without a good reason to do so,
> and
> > while hooks are currently popular, we have not agreed on hooks as our
> > accepted approach going forward.
> >
> > Let's continue the discussion in the Github issue.
> >
> > On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <jy...@gmail.com> wrote:
> >
> >> Hi All,
> >>
> >> I'm calling a vote for
> >> https://github.com/apache/incubator-superset/issues/11688 <
> >> https://github.com/apache/incubator-superset/issues/11688>
> >>
> >> Here's an accompanying PR:
> >> https://github.com/apache/incubator-superset/pull/11771 <
> >> https://github.com/apache/incubator-superset/pull/11771>
> >>
> >>
> >> Thanks,
> >> Jesse
> >>
> >>
> >>
> >
> > --
> >
> > *Rob DiCiuccio* (he/him)
> > Director of Engineering
> > Preset | https://preset.io
> >
>
>
> --
>
> *Rob DiCiuccio* (he/him)
> Director of Engineering
> Preset | https://preset.io
>

[Result][VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Jesse Yang <jy...@gmail.com>.
The vote passes with 6 binding +1 votes, 0 non-binding votes and no -1 vote.

Binding votes:

+1 votes (binding):
Erik Ritter
Maxime Beauchemin
Evan Rusackas
Rob DiCiuccio
Tai Dupree
Ville Brofeldt

Thanks to everyone who participated.

--
Jesse Yang


> On Nov 25, 2020, at 3:08 PM, Rob DiCiuccio <ro...@preset.io> wrote:
> 
> I appreciate the additional insights provided in the Github issue, thanks
> to all for the discussion.
> 
> +1 (binding) on moving forward with RTL on an evaluation basis
> 
> On Wed, Nov 25, 2020 at 10:47 AM Rob DiCiuccio <ro...@preset.io> wrote:
> 
>> I'd like to better understand what problems with the Enzyme testing flow
>> we're trying to solve with this migration. The SIP states only that Enzyme
>> is "running behind in catching up with all the latest React trends" and
>> "doesn’t support the useEffect hook" as rationale. I would argue that we
>> should not be chasing the latest trends without a good reason to do so, and
>> while hooks are currently popular, we have not agreed on hooks as our
>> accepted approach going forward.
>> 
>> Let's continue the discussion in the Github issue.
>> 
>> On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <jy...@gmail.com> wrote:
>> 
>>> Hi All,
>>> 
>>> I'm calling a vote for
>>> https://github.com/apache/incubator-superset/issues/11688 <
>>> https://github.com/apache/incubator-superset/issues/11688>
>>> 
>>> Here's an accompanying PR:
>>> https://github.com/apache/incubator-superset/pull/11771 <
>>> https://github.com/apache/incubator-superset/pull/11771>
>>> 
>>> 
>>> Thanks,
>>> Jesse
>>> 
>>> 
>>> 
>> 
>> --
>> 
>> *Rob DiCiuccio* (he/him)
>> Director of Engineering
>> Preset | https://preset.io
>> 
> 
> 
> -- 
> 
> *Rob DiCiuccio* (he/him)
> Director of Engineering
> Preset | https://preset.io

Re: [VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Rob DiCiuccio <ro...@preset.io>.
I appreciate the additional insights provided in the Github issue, thanks
to all for the discussion.

+1 (binding) on moving forward with RTL on an evaluation basis

On Wed, Nov 25, 2020 at 10:47 AM Rob DiCiuccio <ro...@preset.io> wrote:

> I'd like to better understand what problems with the Enzyme testing flow
> we're trying to solve with this migration. The SIP states only that Enzyme
> is "running behind in catching up with all the latest React trends" and
> "doesn’t support the useEffect hook" as rationale. I would argue that we
> should not be chasing the latest trends without a good reason to do so, and
> while hooks are currently popular, we have not agreed on hooks as our
> accepted approach going forward.
>
> Let's continue the discussion in the Github issue.
>
> On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <jy...@gmail.com> wrote:
>
>> Hi All,
>>
>> I'm calling a vote for
>> https://github.com/apache/incubator-superset/issues/11688 <
>> https://github.com/apache/incubator-superset/issues/11688>
>>
>> Here's an accompanying PR:
>> https://github.com/apache/incubator-superset/pull/11771 <
>> https://github.com/apache/incubator-superset/pull/11771>
>>
>>
>> Thanks,
>> Jesse
>>
>>
>>
>
> --
>
> *Rob DiCiuccio* (he/him)
> Director of Engineering
> Preset | https://preset.io
>


-- 

*Rob DiCiuccio* (he/him)
Director of Engineering
Preset | https://preset.io

Re: [VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Rob DiCiuccio <ro...@preset.io>.
I'd like to better understand what problems with the Enzyme testing flow
we're trying to solve with this migration. The SIP states only that Enzyme
is "running behind in catching up with all the latest React trends" and
"doesn’t support the useEffect hook" as rationale. I would argue that we
should not be chasing the latest trends without a good reason to do so, and
while hooks are currently popular, we have not agreed on hooks as our
accepted approach going forward.

Let's continue the discussion in the Github issue.

On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <jy...@gmail.com> wrote:

> Hi All,
>
> I'm calling a vote for
> https://github.com/apache/incubator-superset/issues/11688 <
> https://github.com/apache/incubator-superset/issues/11688>
>
> Here's an accompanying PR:
> https://github.com/apache/incubator-superset/pull/11771 <
> https://github.com/apache/incubator-superset/pull/11771>
>
>
> Thanks,
> Jesse
>
>
>

-- 

*Rob DiCiuccio* (he/him)
Director of Engineering
Preset | https://preset.io

Re: [VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Evan Rusackas <ev...@preset.io>.
The SIP itself seems very sensible in approach to experimentation and evaluation, and I’m looking forward to kicking the tires on these new toys.

+1 (binding)

Evan Rusackas
( he | him )
Frontend Lead
Preset | preset.io
On Nov 23, 2020, 9:54 PM -0800, Jesse Yang <jy...@gmail.com>, wrote:
> Hi All,
>
> I'm calling a vote for https://github.com/apache/incubator-superset/issues/11688 <https://github.com/apache/incubator-superset/issues/11688>
>
> Here's an accompanying PR: https://github.com/apache/incubator-superset/pull/11771 <https://github.com/apache/incubator-superset/pull/11771>
>
>
> Thanks,
> Jesse
>
>

Re: [VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Maxime Beauchemin <ma...@preset.io>.
+1 binding

On Mon, Nov 23, 2020 at 10:07 PM Erik Ritter <er...@gmail.com>
wrote:

> After playing with RTL a bit in other repos, this seems like the path
> forward for frontend component testing.
>
> +1 binding
>
> Erik
>
> On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <jy...@gmail.com> wrote:
>
> > Hi All,
> >
> > I'm calling a vote for
> > https://github.com/apache/incubator-superset/issues/11688 <
> > https://github.com/apache/incubator-superset/issues/11688>
> >
> > Here's an accompanying PR:
> > https://github.com/apache/incubator-superset/pull/11771 <
> > https://github.com/apache/incubator-superset/pull/11771>
> >
> >
> > Thanks,
> > Jesse
> >
> >
> >
>

Re: [VOTE] SIP-56 Proposal to Adopt React Testing Library

Posted by Erik Ritter <er...@gmail.com>.
After playing with RTL a bit in other repos, this seems like the path
forward for frontend component testing.

+1 binding

Erik

On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <jy...@gmail.com> wrote:

> Hi All,
>
> I'm calling a vote for
> https://github.com/apache/incubator-superset/issues/11688 <
> https://github.com/apache/incubator-superset/issues/11688>
>
> Here's an accompanying PR:
> https://github.com/apache/incubator-superset/pull/11771 <
> https://github.com/apache/incubator-superset/pull/11771>
>
>
> Thanks,
> Jesse
>
>
>