You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/10/09 10:56:06 UTC

[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #255: [TYPO] Replace Chinese colon by ASCII colon

kaijchen opened a new pull request, #255:
URL: https://github.com/apache/incubator-uniffle/pull/255

   ### What changes were proposed in this pull request?
   
   Replace `：` by `: `.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   No need.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerryshao commented on pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
jerryshao commented on PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255#issuecomment-1272731175

   It would be better to cherry-pick this to 0.6 branch and kick off a new RC release. CC\ @jerqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] zuston merged pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
zuston merged PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255#issuecomment-1272735860

   > It would be better to cherry-pick this to 0.6 branch and kick off a new RC release. CC\ @jerqi
   
   Ok, I will cherry-pick this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255#issuecomment-1272521162

   @zuston Kerberos test seems flaky.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] zuston commented on pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
zuston commented on PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255#issuecomment-1272715893

   > @zuston Kerberos test seems flaky.
   
   Yes. This test makes me confused, I will take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255#issuecomment-1272519561

   # [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/255?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#255](https://codecov.io/gh/apache/incubator-uniffle/pull/255?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a4dd95) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/c89f95cd7876d52c38d5fc080913d38d42cb5fa1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c89f95c) will **decrease** coverage by `0.02%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #255      +/-   ##
   ============================================
   - Coverage     59.16%   59.13%   -0.03%     
   + Complexity     1340     1339       -1     
   ============================================
     Files           163      163              
     Lines          8810     8810              
     Branches        833      833              
   ============================================
   - Hits           5212     5210       -2     
   - Misses         3332     3333       +1     
   - Partials        266      267       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../hadoop/mapreduce/task/reduce/RssBypassWriter.java](https://codecov.io/gh/apache/incubator-uniffle/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0J5cGFzc1dyaXRlci5qYXZh) | `61.90% <0.00%> (ø)` | |
   | [...pache/hadoop/mapreduce/task/reduce/RssFetcher.java](https://codecov.io/gh/apache/incubator-uniffle/pull/255/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0ZldGNoZXIuamF2YQ==) | `89.06% <0.00%> (-1.57%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] kaijchen commented on pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255#issuecomment-1272727552

   Thanks @zuston for merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] zuston commented on pull request #255: [TYPO] Replace Chinese colon by ASCII colon

Posted by GitBox <gi...@apache.org>.
zuston commented on PR #255:
URL: https://github.com/apache/incubator-uniffle/pull/255#issuecomment-1272727196

   Merged. Thanks @kaijchen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org