[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1108: ORC-1167: Support `orc.row.batch.size` configuration

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #1108:
URL: https://github.com/apache/orc/pull/1108#discussion_r867411746


##########
java/core/src/java/org/apache/orc/OrcConf.java:
##########
@@ -219,7 +219,11 @@ public enum OrcConf {
       "orc.proleptic.gregorian.default", false,
       "This value controls whether pre-ORC 27 files are using the hybrid or proleptic\n" +
       "calendar. Only Hive 3.1 and the C++ library wrote using the proleptic, so hybrid\n" +
-      "is the default.")
+      "is the default."),
+  ROW_BATCH_SIZE("orc.row.batch.size", "orc.row.batch.size", 1024,
+          "The number of rows to include in a orc vectorized reader batch. " +
+                  "The number should be carefully chosen to minimize overhead " +
+                  "and avoid OOMs in reading data.")

Review Comment:
   The following will be enough. I also change `number` to `value` in the second sentence.
   ```java
     ROW_BATCH_SIZE("orc.row.batch.size", "orc.row.batch.size", 1024,
         "The number of rows to include in a orc vectorized reader batch. " +
         "The value should be carefully chosen to minimize overhead and avoid OOMs in reading data.")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org