You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ssisk <gi...@git.apache.org> on 2017/04/25 00:27:18 UTC

[GitHub] beam pull request #2671: [BEAM-2033] Add HadoopResourceId

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2671

    [BEAM-2033] Add HadoopResourceId

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    merging person: I believe we'll want to do the implementation of this in a feature branch - this'd be a good time to create that feature branch. 
    
    R: @tgroh 
    
    It's worth noting that GcsResourceId spends a lot of time on worrying about slashes - that's not a thing we'll need for this since Hadoop's Path does a good job of cleaning it up, so all that's handled at a lower level.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam hfs-pre-req

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2671
    
----
commit 405cc1471c4fb0668c30fe6ffa232bd21c31c4ee
Author: Stephen Sisk <si...@google.com>
Date:   2017-04-22T00:23:55Z

    Add HadoopResourceId

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2671: [BEAM-2033] Add HadoopResourceId

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2671


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---