You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/06/01 05:56:22 UTC

[GitHub] [trafficserver] zwoop commented on a diff in pull request #9707: Add a new configuration to ignore query params in cache keys

zwoop commented on code in PR #9707:
URL: https://github.com/apache/trafficserver/pull/9707#discussion_r1212613649


##########
proxy/http/HttpConfig.h:
##########
@@ -618,19 +619,19 @@ struct OverridableHttpConfigParams {
   /////////////////////////////////////////////////
   MgmtByte response_suppression_mode = 0; // proxy.config.body_factory.response_suppression_mode
 
+  //////////////////
+  // Redirection  //
+  //////////////////
+  MgmtByte redirect_use_orig_cache_key = 0;
+  MgmtInt number_of_redirections       = 0;
+

Review Comment:
   @ywkaras Well played. I can move these out if you prefer, having these out of "byte order" so to speak just rubs me the wrong way since they add so much uneccesary padding to the structs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org