You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Emmanuel Bourg <eb...@apache.org> on 2017/12/11 00:21:28 UTC
Re: svn commit: r1816418 - in /tomcat/trunk:
java/javax/websocket/WebSocketContainer.java
java/org/apache/tomcat/websocket/WsWebSocketContainer.java
test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java
Le 27/11/2017 à 11:33, markt@apache.org a écrit :
> Modified: tomcat/trunk/java/javax/websocket/WebSocketContainer.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/websocket/WebSocketContainer.java?rev=1816418&r1=1816417&r2=1816418&view=diff
> ==============================================================================
> --- tomcat/trunk/java/javax/websocket/WebSocketContainer.java (original)
> +++ tomcat/trunk/java/javax/websocket/WebSocketContainer.java Mon Nov 27 10:33:22 2017
> @@ -33,9 +33,20 @@ public interface WebSocketContainer {
> * Set the default timeout for sending a message asynchronously.
> * @param timeout The new default timeout in milliseconds. A non-positive
> * value means an infinite timeout.
> + *
> + * @deprecated This will be removed in Tomcat 9.
> + * Use {@link #setDefaultAsyncSendTimeout(long)}
> */
> + @Deprecated
> void setAsyncSendTimeout(long timeout);
>
> + /**
> + * Set the default timeout for sending a message asynchronously.
> + * @param timeout The new default timeout in milliseconds. A non-positive
> + * value means an infinite timeout.
> + */
> + void setDefaultAsyncSendTimeout(long timeout);
> +
Hi Mark,
The extra setDefaultAsyncSendTimeout method in WebSocketContainer isn't
defined in the WebSocket API 1.1. Is this divergence with the
specification intended? In Debian the tomcat-websocket-api artifact is
used as the reference WebSocket API and this change caused a couple of
packages to fail to build.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1816418 - in /tomcat/trunk:
java/javax/websocket/WebSocketContainer.java
java/org/apache/tomcat/websocket/WsWebSocketContainer.java
test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java
Posted by Mark Thomas <ma...@apache.org>.
On 11/12/17 00:21, Emmanuel Bourg wrote:
> Le 27/11/2017 à 11:33, markt@apache.org a écrit :
>
>> Modified: tomcat/trunk/java/javax/websocket/WebSocketContainer.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/websocket/WebSocketContainer.java?rev=1816418&r1=1816417&r2=1816418&view=diff
>> ==============================================================================
>> --- tomcat/trunk/java/javax/websocket/WebSocketContainer.java (original)
>> +++ tomcat/trunk/java/javax/websocket/WebSocketContainer.java Mon Nov 27 10:33:22 2017
>> @@ -33,9 +33,20 @@ public interface WebSocketContainer {
>> * Set the default timeout for sending a message asynchronously.
>> * @param timeout The new default timeout in milliseconds. A non-positive
>> * value means an infinite timeout.
>> + *
>> + * @deprecated This will be removed in Tomcat 9.
>> + * Use {@link #setDefaultAsyncSendTimeout(long)}
>> */
>> + @Deprecated
>> void setAsyncSendTimeout(long timeout);
>>
>> + /**
>> + * Set the default timeout for sending a message asynchronously.
>> + * @param timeout The new default timeout in milliseconds. A non-positive
>> + * value means an infinite timeout.
>> + */
>> + void setDefaultAsyncSendTimeout(long timeout);
>> +
>
> Hi Mark,
>
> The extra setDefaultAsyncSendTimeout method in WebSocketContainer isn't
> defined in the WebSocket API 1.1. Is this divergence with the
> specification intended? In Debian the tomcat-websocket-api artifact is
> used as the reference WebSocket API and this change caused a couple of
> packages to fail to build.
That is an error on my part. I'll get it fixed.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org