You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Alexander Alten-Lorenz <al...@cloudera.com> on 2013/02/13 10:38:23 UTC

Review Request: [Flume-1881] Set log level for File Channel's checkpoint time warning to INFO

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9422/
-----------------------------------------------------------

Review request for Flume.


Description
-------

As mentioned here:
(http://mail-archives.apache.org/mod_mbox/flume-dev/201301.mbox/%3CCAH0o75Og85wn_Yx%2BmAQKqTVrKdRzv7DToGo%2B%3DiRqtnn3%2BoD_5g%40mail.gmail.com%3E)
There is an unnecessary WARN message played sometimes when the File Channel starts.


This addresses bug Flume-1881.
    https://issues.apache.org/jira/browse/Flume-1881


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 1db3717 

Diff: https://reviews.apache.org/r/9422/diff/


Testing
-------


Thanks,

Alexander Alten-Lorenz


Re: Review Request: [Flume-1881] Set log level for File Channel's checkpoint time warning to INFO (in behalf of Connor Woodson)

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9422/
-----------------------------------------------------------

(Updated Feb. 13, 2013, 9:42 a.m.)


Review request for Flume.


Summary (updated)
-----------------

[Flume-1881] Set log level for File Channel's checkpoint time warning to INFO (in behalf of Connor Woodson)


Description
-------

As mentioned here:
(http://mail-archives.apache.org/mod_mbox/flume-dev/201301.mbox/%3CCAH0o75Og85wn_Yx%2BmAQKqTVrKdRzv7DToGo%2B%3DiRqtnn3%2BoD_5g%40mail.gmail.com%3E)
There is an unnecessary WARN message played sometimes when the File Channel starts.


This addresses bug Flume-1881.
    https://issues.apache.org/jira/browse/Flume-1881


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 1db3717 

Diff: https://reviews.apache.org/r/9422/diff/


Testing
-------


Thanks,

Alexander Alten-Lorenz


Re: Review Request: [Flume-1881] Set log level for File Channel's checkpoint time warning to INFO

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9422/#review16508
-----------------------------------------------------------


INFO looks fine to me for the startup process, but not when the Channel is initialized and running. Do you think you can extend your patch?

- Alexander Alten-Lorenz


On Feb. 13, 2013, 9:38 a.m., Alexander Alten-Lorenz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9422/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 9:38 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> As mentioned here:
> (http://mail-archives.apache.org/mod_mbox/flume-dev/201301.mbox/%3CCAH0o75Og85wn_Yx%2BmAQKqTVrKdRzv7DToGo%2B%3DiRqtnn3%2BoD_5g%40mail.gmail.com%3E)
> There is an unnecessary WARN message played sometimes when the File Channel starts.
> 
> 
> This addresses bug Flume-1881.
>     https://issues.apache.org/jira/browse/Flume-1881
> 
> 
> Diffs
> -----
> 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 1db3717 
> 
> Diff: https://reviews.apache.org/r/9422/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Alten-Lorenz
> 
>