You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2005/09/18 22:00:10 UTC
[jira] Created: (MPRELEASE-12) The encoding of the project.xml file is not preserved after doing release:transform
The encoding of the project.xml file is not preserved after doing release:transform
-----------------------------------------------------------------------------------
Key: MPRELEASE-12
URL: http://jira.codehaus.org/browse/MPRELEASE-12
Project: maven-release-plugin
Type: Bug
Environment: Windows XP Pro, Maven 1.0.2, release-plugin 1.4.1.
Reporter: Dennis Lundberg
This is similar in concept to MPCHANGES-24.
The encoding of the original project.xml file is not preserved when it is written back after the transformation. This means that my file was converted from ISO-8859-1 to UTF-8, which is the default encoding used by dom4j. Without a UTF-8 compliant editor I can't edit the file any more, because I use non-us-ascii character in the file.
The solution should be similar and the place to make the change is in this file:
http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins/trunk/release/src/main/org/apache/maven/release/AbstractPomTransformer.java
The method write() needs to get a hold of the original file's encoding, and do
format.setEncoding(<original-encoding>);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPRELEASE-12) The encoding of the project.xml file
is not preserved after doing release:transform
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPRELEASE-12?page=all ]
Lukas Theussl closed MPRELEASE-12:
----------------------------------
Resolution: Fixed
Fix Version: 1.5
Patch applied. Thanks!
> The encoding of the project.xml file is not preserved after doing release:transform
> -----------------------------------------------------------------------------------
>
> Key: MPRELEASE-12
> URL: http://jira.codehaus.org/browse/MPRELEASE-12
> Project: maven-release-plugin
> Type: Bug
> Environment: Windows XP Pro, Maven 1.0.2, release-plugin 1.4.1.
> Reporter: Dennis Lundberg
> Fix For: 1.5
> Attachments: MPRELEASE-12.patch
>
>
> This is similar in concept to MPCHANGES-24.
> The encoding of the original project.xml file is not preserved when it is written back after the transformation. This means that my file was converted from ISO-8859-1 to UTF-8, which is the default encoding used by dom4j. Without a UTF-8 compliant editor I can't edit the file any more, because I use non-us-ascii character in the file.
> The solution should be similar and the place to make the change is in this file:
> http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins/trunk/release/src/main/org/apache/maven/release/AbstractPomTransformer.java
> The method write() needs to get a hold of the original file's encoding, and do
> format.setEncoding(<original-encoding>);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPRELEASE-12) The encoding of the project.xml file is not preserved after doing release:transform
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPRELEASE-12?page=all ]
Dennis Lundberg updated MPRELEASE-12:
-------------------------------------
Attachment: MPRELEASE-12.patch
This patch is inspired by Lukas' fix for MPCHANGES-24.
It adds a new write method in AbstractPomTransformer.java that takes an encoding parameter. In plugin-jelly this new write method is used everywhere. I have tested the goal release:update-pom, the other goals are modified in a similar way.
The missing thing in the patch is a suitable developer in changes.xml.
> The encoding of the project.xml file is not preserved after doing release:transform
> -----------------------------------------------------------------------------------
>
> Key: MPRELEASE-12
> URL: http://jira.codehaus.org/browse/MPRELEASE-12
> Project: maven-release-plugin
> Type: Bug
> Environment: Windows XP Pro, Maven 1.0.2, release-plugin 1.4.1.
> Reporter: Dennis Lundberg
> Attachments: MPRELEASE-12.patch
>
>
> This is similar in concept to MPCHANGES-24.
> The encoding of the original project.xml file is not preserved when it is written back after the transformation. This means that my file was converted from ISO-8859-1 to UTF-8, which is the default encoding used by dom4j. Without a UTF-8 compliant editor I can't edit the file any more, because I use non-us-ascii character in the file.
> The solution should be similar and the place to make the change is in this file:
> http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins/trunk/release/src/main/org/apache/maven/release/AbstractPomTransformer.java
> The method write() needs to get a hold of the original file's encoding, and do
> format.setEncoding(<original-encoding>);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org