You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/11/13 01:01:32 UTC
Review Request 27942: Don't fail builds on exceeded coverage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27942/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Don't fail builds on exceeded coverage.
Diffs
-----
buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy PRE-CREATION
Diff: https://reviews.apache.org/r/27942/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 27942: Don't fail builds on exceeded coverage.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27942/#review61144
-----------------------------------------------------------
Ship it!
Master (b80e69c) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 13, 2014, 12:01 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27942/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 12:01 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Don't fail builds on exceeded coverage.
>
>
> Diffs
> -----
>
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27942: Don't fail builds on exceeded coverage.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27942/#review61138
-----------------------------------------------------------
Not sure what's up with this diff, but i don't think we want this to be an empty file.
- Bill Farner
On Nov. 13, 2014, 12:01 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27942/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 12:01 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Don't fail builds on exceeded coverage.
>
>
> Diffs
> -----
>
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27942: Don't fail builds on exceeded coverage.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27942/#review61136
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Nov. 13, 2014, 12:01 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27942/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 12:01 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Don't fail builds on exceeded coverage.
>
>
> Diffs
> -----
>
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27942: Don't fail builds on exceeded coverage.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27942/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 4:01 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
Description
-------
Don't fail builds on exceeded coverage.
Diffs
-----
buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy PRE-CREATION
Diff: https://reviews.apache.org/r/27942/diff/
Testing
-------
Thanks,
Zameer Manji