You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/02 13:23:37 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #14024: Allow list item to be rendered as taget renderer instead of showing JSON

turbaszek commented on a change in pull request #14024:
URL: https://github.com/apache/airflow/pull/14024#discussion_r568596620



##########
File path: airflow/www/views.py
##########
@@ -898,7 +898,7 @@ def rendered_templates(self):
             content = getattr(task, template_field)
             renderer = task.template_fields_renderers.get(template_field, template_field)
             if renderer in renderers:
-                if isinstance(content, (dict, list)):
+                if isinstance(content, dict):

Review comment:
       ```suggestion
                   if renderer == "json" and isinstance(content, (dict, list)):
   ```
   This will probably be better approach as will solve your problem and preserve the current behavior for fields marked as `json`. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org