You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/03/20 03:11:47 UTC
[GitHub] [rocketmq] dongeforever commented on a change in pull request
#1079: [ISSUE #1078]fix User can't use mqadmin command normally if they
don't copy the tool.yml file to related fold and AclEnable flag is closed.
dongeforever commented on a change in pull request #1079: [ISSUE #1078]fix User can't use mqadmin command normally if they don't copy the tool.yml file to related fold and AclEnable flag is closed.
URL: https://github.com/apache/rocketmq/pull/1079#discussion_r267172311
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java
##########
@@ -249,8 +249,13 @@ public static void initCommand(SubCommand command) {
public static RPCHook getAclRPCHook() {
String fileHome = System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY, System.getenv(MixAll.ROCKETMQ_HOME_ENV));
String fileName = "/conf/tools.yml";
- JSONObject yamlDataObject = AclUtils.getYamlDataObject(fileHome + fileName ,
+ JSONObject yamlDataObject = null;
+ try {
+ yamlDataObject = AclUtils.getYamlDataObject(fileHome + fileName,
JSONObject.class);
+ } catch (Exception e) {
+ e.printStackTrace();
Review comment:
Do not printStackTraceļ¼just ignored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services