You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/07 07:34:22 UTC
[GitHub] [airflow] Frank-T-Johansen opened a new issue, #24893: Wrong syntax in mssql setup documentation
Frank-T-Johansen opened a new issue, #24893:
URL: https://github.com/apache/airflow/issues/24893
### What do you see as an issue?
https://airflow.apache.org/docs/apache-airflow/stable/howto/set-up-database.html#setting-up-a-mssql-database
Documentation says:
GRANT ALL PRIVILEGES ON DATABASE airflow TO airflow_user;
For MSSQL 2019 patchlevel 15.0.4236.7 the correct syntax is:
GRANT ALL PRIVILEGES ON DATABASE::airflow TO airflow_user;
Only the latter works, although I still get a warning that it is deprecated.
### Solving the problem
Updating documentation with new alternative, maybe depending on mssql version.
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on issue #24893: Wrong syntax in mssql setup documentation
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #24893:
URL: https://github.com/apache/airflow/issues/24893#issuecomment-1179583636
Fixed in #24939.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #24893: Wrong syntax in mssql setup documentation
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #24893:
URL: https://github.com/apache/airflow/issues/24893#issuecomment-1177197172
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed issue #24893: Wrong syntax in mssql setup documentation
Posted by GitBox <gi...@apache.org>.
jedcunningham closed issue #24893: Wrong syntax in mssql setup documentation
URL: https://github.com/apache/airflow/issues/24893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #24893: Wrong syntax in mssql setup documentation
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #24893:
URL: https://github.com/apache/airflow/issues/24893#issuecomment-1177239366
Go ahead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nigel-millward commented on issue #24893: Wrong syntax in mssql setup documentation
Posted by GitBox <gi...@apache.org>.
nigel-millward commented on issue #24893:
URL: https://github.com/apache/airflow/issues/24893#issuecomment-1177229185
Hi! I'm a newbie, I'll pick up this good-first-issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nigel-millward commented on issue #24893: Wrong syntax in mssql setup documentation
Posted by GitBox <gi...@apache.org>.
nigel-millward commented on issue #24893:
URL: https://github.com/apache/airflow/issues/24893#issuecomment-1179500090
All links below point to using new syntax
SQL patch: https://support.microsoft.com/en-us/topic/kb4518398-sql-server-2019-build-versions-782ed548-1cd8-b5c3-a566-8b4f9e20293a
2022 preview: https://docs.microsoft.com/en-us/sql/t-sql/statements/grant-database-permissions-transact-sql?view=sql-server-ver16
2019: https://docs.microsoft.com/en-us/sql/t-sql/statements/grant-database-permissions-transact-sql?view=sql-server-ver15
2017: https://docs.microsoft.com/en-us/sql/t-sql/statements/grant-database-permissions-transact-sql?view=sql-server-2017
Airflow supports the following database engine versions
PostgreSQL: 10, 11, 12, 13
MySQL: 5.7, 8
MsSQL: 2017, 2019
SQLite: 3.15.0+
Tested on mssql 2017 and 2019, both worked fine with the new syntax
Updated docs to the later version
Created a PR: https://github.com/apache/airflow/pull/24939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org