[GitHub] ThomasDelteil commented on issue #11293: Update cached_op.cc

[GitBox <gi...@apache.org>]

ThomasDelteil commented on issue #11293: Update cached_op.cc
URL: https://github.com/apache/incubator-mxnet/pull/11293#issuecomment-397449059
 
 
   Thanks @piiswrong for updating the code
   
   this is related to this PR https://github.com/apache/incubator-mxnet/pull/10817
   Using the `static_alloc` and `static_shape` flag set to `True` I experienced slower training.
   
   The `hybridize()` doc says:
   ```
   Must also  set static_alloc to True. Change of input shapes is still allowed but slower. 
   ```
   
   Should we have an assert:
   ```python
   if static_shape:
   assert static_alloc, "static_alloc must be `True` if static_shape is `True`"
   ```
   
   What is the consequence of having one without the other?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services