You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/28 11:21:41 UTC
[GitHub] [calcite] DonnyZone commented on a change in pull request #1532: [CALCITE-3448] AggregateOnProjectToAggregateUnifyRule ignores Project…
DonnyZone commented on a change in pull request #1532: [CALCITE-3448] AggregateOnProjectToAggregateUnifyRule ignores Project…
URL: https://github.com/apache/calcite/pull/1532#discussion_r339512369
##########
File path: core/src/main/java/org/apache/calcite/util/mapping/Mappings.java
##########
@@ -434,7 +434,9 @@ public static boolean keepsOrdering(TargetMapping mapping) {
if (target != -1 && target < prevTarget) {
return false;
}
- prevTarget = target;
+ if (target != -1) {
Review comment:
Maybe we can combine two `if` clause together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services