You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by jfrazee <gi...@git.apache.org> on 2016/10/21 18:24:28 UTC
[GitHub] incubator-streams pull request #308: STREAMS-432 Update to Java 8
GitHub user jfrazee opened a pull request:
https://github.com/apache/incubator-streams/pull/308
STREAMS-432 Update to Java 8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrazee/incubator-streams STREAMS-432
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #308
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #308: STREAMS-432 Update to Java 8
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/308#discussion_r84527171
--- Diff: incubator-streams-master-pom.xml ---
@@ -117,11 +117,12 @@
<properties>
<!-- Build Properties -->
- <java.version>1.7</java.version>
+ <java.version>1.8</java.version>
+ <maven.version>3.0.5</maven.version>
--- End diff --
Change to 3.3.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #308: STREAMS-432 Update to Java 8
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-streams/pull/308
How about enforcing Java 8 and mmaven 3.3.9 like this?
` <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>1.4</version>
<executions>
<execution>
<id>enforce-versions</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireJavaVersion>
<version>[1.7,)</version>
</requireJavaVersion>
<requireMavenVersion>
<version>[3.3.3,)</version>
</requireMavenVersion>
</rules>
</configuration>
</execution>
</executions>
</plugin>`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #308: STREAMS-432 Update to Java 8
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #308: STREAMS-432 Update to Java 8
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-streams/pull/308
+1 LGTM, we could remove the declarations for both java and maven once we include the maven-enforcer-plugin and enforce the respective versions within there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #308: STREAMS-432 Update to Java 8
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/308#discussion_r84528708
--- Diff: incubator-streams-master-pom.xml ---
@@ -117,11 +117,12 @@
<properties>
<!-- Build Properties -->
- <java.version>1.7</java.version>
+ <java.version>1.8</java.version>
+ <maven.version>3.0.5</maven.version>
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #308: STREAMS-432 Update to Java 8
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/incubator-streams/pull/308
@smarthi That is what it's doing, but without the enforcement for Maven, so I'll add the Maven check and push back to the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #308: STREAMS-432 Update to Java 8
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/308#discussion_r84527128
--- Diff: incubator-streams-master-pom.xml ---
@@ -322,9 +323,13 @@
<configuration>
<rules>
<requireJavaVersion>
- <message>Java 6 or higher is required to compile this module</message>
- <version>${java.version}</version>
+ <message>Java 8 or higher is required to compile this module</message>
+ <version>[${java.version},)</version>
</requireJavaVersion>
+ <requireMavenVersion>
+ <message>Maven 3.0 or higher is required to compile this module</message>
--- End diff --
Enforce Maven 3.3.9 or higher
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---