You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2024/04/08 15:33:20 UTC
[PR] feat(deps): Upgrade controller-runtime to 0.16.x [camel-k]
gansheer opened a new pull request, #5335:
URL: https://github.com/apache/camel-k/pull/5335
Ref #5211
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat(deps): Upgrade controller-runtime to 0.16.x
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(deps): Upgrade controller-runtime to 0.16.x [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #5335:
URL: https://github.com/apache/camel-k/pull/5335#discussion_r1556096862
##########
go.mod:
##########
@@ -53,7 +53,7 @@ require (
knative.dev/eventing v0.39.3
knative.dev/pkg v0.0.0-20231023151236-29775d7c9e5c
knative.dev/serving v0.39.3
- sigs.k8s.io/controller-runtime v0.15.2
+ sigs.k8s.io/controller-runtime v0.16.0
Review Comment:
That's the plan, but for now I make the minimal change to see if the cache works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(deps): Upgrade controller-runtime to 0.16.x [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer merged PR #5335:
URL: https://github.com/apache/camel-k/pull/5335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(deps): Upgrade controller-runtime to 0.16.x [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5335:
URL: https://github.com/apache/camel-k/pull/5335#discussion_r1556065860
##########
go.mod:
##########
@@ -53,7 +53,7 @@ require (
knative.dev/eventing v0.39.3
knative.dev/pkg v0.0.0-20231023151236-29775d7c9e5c
knative.dev/serving v0.39.3
- sigs.k8s.io/controller-runtime v0.15.2
+ sigs.k8s.io/controller-runtime v0.16.0
Review Comment:
I think we can bump to `0.16.5` in one shot. In theory, the biggest problem would be the incompatibility with the minor. The patch should introduce no breaking changes I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(deps): Upgrade controller-runtime to 0.16.x [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5335:
URL: https://github.com/apache/camel-k/pull/5335#discussion_r1561208633
##########
go.mod:
##########
@@ -52,8 +52,8 @@ require (
k8s.io/utils v0.0.0-20230505201702-9f6742963106
knative.dev/eventing v0.40.3
knative.dev/pkg v0.0.0-20240116073220-b488e7be5902
- knative.dev/serving v0.40.1
- sigs.k8s.io/controller-runtime v0.15.2
+ knative.dev/serving v0.39.3
Review Comment:
Why downgrading this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(deps): Upgrade controller-runtime to 0.16.x [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #5335:
URL: https://github.com/apache/camel-k/pull/5335#discussion_r1561211807
##########
go.mod:
##########
@@ -52,8 +52,8 @@ require (
k8s.io/utils v0.0.0-20230505201702-9f6742963106
knative.dev/eventing v0.40.3
knative.dev/pkg v0.0.0-20240116073220-b488e7be5902
- knative.dev/serving v0.40.1
- sigs.k8s.io/controller-runtime v0.15.2
+ knative.dev/serving v0.39.3
Review Comment:
That's probably a mistake, I will upgrade it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org