You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/19 03:59:01 UTC

[GitHub] [incubator-eventmesh] pchengma opened a new issue, #1315: [Enhancement] Knative Connector: Remove Unnecessary Unit Test of Consumer

pchengma opened a new issue, #1315:
URL: https://github.com/apache/incubator-eventmesh/issues/1315

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   Since the original unit test in ```KnativeConsumerImplTest``` needs the prerequisite of installing Knative source/sink and broker, it will cause the test to fail in the CI process.
   
   ### Describe the solution you'd like
   
   Remove ```KnativeConsumerImplTest.java``` file and use the integration test for consumer as described in [document](https://github.com/apache/incubator-eventmesh/blob/master/docs/zh/connector-knative/01-eventmesh-connector-knative.md).
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] pchengma closed issue #1315: [Enhancement] Knative Connector: Remove Unnecessary Unit Test of Consumer

Posted by GitBox <gi...@apache.org>.
pchengma closed issue #1315: [Enhancement] Knative Connector: Remove Unnecessary Unit Test of Consumer
URL: https://github.com/apache/incubator-eventmesh/issues/1315


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org