You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/04 07:04:03 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
KarmaGYZ opened a new pull request #14862:
URL: https://github.com/apache/flink/pull/14862
…quirements
## What is the purpose of the change
Remove unused ExecutionVertexSchedulingRequirements.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
cc @zhuzhurk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #14862:
URL: https://github.com/apache/flink/pull/14862#discussion_r570744967
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocator.java
##########
@@ -115,15 +115,11 @@
* returns the results.
* </ol>
*
- * @param executionVertexSchedulingRequirements the requirements for scheduling the executions.
+ * @param executionVertexIds the requirements for scheduling the executions.
Review comment:
the comment is outdated
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotAllocator.java
##########
@@ -29,10 +29,10 @@
/**
* Allocate slots for the given executions.
*
- * @param executionVertexSchedulingRequirements The requirements for scheduling the executions.
+ * @param executionVertexIds The requirements for scheduling the executions.
Review comment:
"The requirements for scheduling the executions" -> "Execution vertices to allocate slots for"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773085972
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 69f0d6e755b3f962c04b043adb50f87241ee959f (Fri May 28 08:57:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773094565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908",
"triggerID" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"triggerType" : "PUSH"
}, {
"hash" : "69f0d6e755b3f962c04b043adb50f87241ee959f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13034",
"triggerID" : "69f0d6e755b3f962c04b043adb50f87241ee959f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f762a60fb9cc869720abebab6f4f081a3c843140 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908)
* 69f0d6e755b3f962c04b043adb50f87241ee959f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773085972
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f762a60fb9cc869720abebab6f4f081a3c843140 (Thu Feb 04 07:09:29 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773094565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908",
"triggerID" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f762a60fb9cc869720abebab6f4f081a3c843140 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773094565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f762a60fb9cc869720abebab6f4f081a3c843140 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-774577631
Thanks for the review @zhuzhurk . I've addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk merged pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #14862:
URL: https://github.com/apache/flink/pull/14862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773094565
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #14862:
URL: https://github.com/apache/flink/pull/14862#discussion_r570744967
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocator.java
##########
@@ -115,15 +115,11 @@
* returns the results.
* </ol>
*
- * @param executionVertexSchedulingRequirements the requirements for scheduling the executions.
+ * @param executionVertexIds the requirements for scheduling the executions.
Review comment:
the comment is outdated
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotAllocator.java
##########
@@ -29,10 +29,10 @@
/**
* Allocate slots for the given executions.
*
- * @param executionVertexSchedulingRequirements The requirements for scheduling the executions.
+ * @param executionVertexIds The requirements for scheduling the executions.
Review comment:
"The requirements for scheduling the executions" -> "Execution vertices to allocate slots for"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773094565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908",
"triggerID" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f762a60fb9cc869720abebab6f4f081a3c843140 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773094565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908",
"triggerID" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"triggerType" : "PUSH"
}, {
"hash" : "69f0d6e755b3f962c04b043adb50f87241ee959f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13034",
"triggerID" : "69f0d6e755b3f962c04b043adb50f87241ee959f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69f0d6e755b3f962c04b043adb50f87241ee959f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773085972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14862:
URL: https://github.com/apache/flink/pull/14862#issuecomment-773094565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908",
"triggerID" : "f762a60fb9cc869720abebab6f4f081a3c843140",
"triggerType" : "PUSH"
}, {
"hash" : "69f0d6e755b3f962c04b043adb50f87241ee959f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "69f0d6e755b3f962c04b043adb50f87241ee959f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f762a60fb9cc869720abebab6f4f081a3c843140 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12908)
* 69f0d6e755b3f962c04b043adb50f87241ee959f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org