You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@guacamole.apache.org by "Stu B (Jira)" <ji...@apache.org> on 2022/03/29 12:16:00 UTC
[jira] [Updated] (GUACAMOLE-1570) start.sh SAML Extension load logic incomplete
[ https://issues.apache.org/jira/browse/GUACAMOLE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu B updated GUACAMOLE-1570:
-----------------------------
Description:
The logic contained within the current start.sh script is incomplete when deciding to load the guacamole-auth-saml extension.
As per [the documentation|https://guacamole.apache.org/doc/gug/saml-auth.html#] the SAML Extension can be configured by setting either `$SAML_IDP_METADATA_URL` or `$SAML_ENTITY_ID` and `$SAML_CALLBACK_URL`
At [line 1049 in script start.sh|https://github.com/apache/guacamole-client/blob/a3e202e6bfb3053d949e0d73ca9364393ef610df/guacamole-docker/bin/start.sh#L1048] the SAML Extension is only loaded if `$SAML_IDP_METADATA_URL` is present.
{code:java}
if [ -n "$SAML_IDP_METADATA_URL" ]; then
associate_saml
INSTALLED_AUTH="$INSTALLED_AUTH saml"
fi{code}
This should include logic similar to [line 754|https://github.com/apache/guacamole-client/blob/a3e202e6bfb3053d949e0d73ca9364393ef610df/guacamole-docker/bin/start.sh#L754] in the same start.sh
{code:java}
if [ -z "$SAML_IDP_METADATA_URL" ] && [ -z "$SAML_ENTITY_ID" -o -z "$SAML_CALLBACK_URL" ]{code}
was:
The logic contained within the current start.sh script is incomplete when deciding to load the guacamole-auth-saml extension.
As per [the documentation|https://guacamole.apache.org/doc/gug/saml-auth.html#] the SAML Extension can be configured by setting either `$SAML_IDP_METADATA_URL` or `$SAML_ENTITY_ID` and `$SAML_CALLBACK_URL`
At [line 1049 in script start.sh|https://github.com/apache/guacamole-client/blob/a3e202e6bfb3053d949e0d73ca9364393ef610df/guacamole-docker/bin/start.sh#L1048] the SAML Extension is only loaded if `$SAML_IDP_METADATA_URL` is present.
{code:java}
if [ -n "$SAML_IDP_METADATA_URL" ]; then
associate_saml
INSTALLED_AUTH="$INSTALLED_AUTH saml"
fi{code}
This should include logic similar to [line 754|https://github.com/apache/guacamole-client/blob/a3e202e6bfb3053d949e0d73ca9364393ef610df/guacamole-docker/bin/start.sh#L754] in the same start.sh
{code:java}
if [ -z "$SAML_IDP_METADATA_URL" ] && [ -z "$SAML_ENTITY_ID" -o -z "$SAML_CALLBACK_URL" ]{code}
> start.sh SAML Extension load logic incomplete
> ---------------------------------------------
>
> Key: GUACAMOLE-1570
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1570
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-docker
> Reporter: Stu B
> Priority: Major
>
> The logic contained within the current start.sh script is incomplete when deciding to load the guacamole-auth-saml extension.
> As per [the documentation|https://guacamole.apache.org/doc/gug/saml-auth.html#] the SAML Extension can be configured by setting either `$SAML_IDP_METADATA_URL` or `$SAML_ENTITY_ID` and `$SAML_CALLBACK_URL`
> At [line 1049 in script start.sh|https://github.com/apache/guacamole-client/blob/a3e202e6bfb3053d949e0d73ca9364393ef610df/guacamole-docker/bin/start.sh#L1048] the SAML Extension is only loaded if `$SAML_IDP_METADATA_URL` is present.
> {code:java}
> if [ -n "$SAML_IDP_METADATA_URL" ]; then
> associate_saml
> INSTALLED_AUTH="$INSTALLED_AUTH saml"
> fi{code}
> This should include logic similar to [line 754|https://github.com/apache/guacamole-client/blob/a3e202e6bfb3053d949e0d73ca9364393ef610df/guacamole-docker/bin/start.sh#L754] in the same start.sh
> {code:java}
> if [ -z "$SAML_IDP_METADATA_URL" ] && [ -z "$SAML_ENTITY_ID" -o -z "$SAML_CALLBACK_URL" ]{code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)