You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 10:25:12 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7414: arch/armv6-m: fix compile error on LLVM clang
anchao opened a new pull request, #7414:
URL: https://github.com/apache/incubator-nuttx/pull/7414
## Summary
arch/armv6-m: fix compile error on LLVM clang
```
armv6-m/arm_exception.S:139:2: error: invalid instruction, any one of the following would fix this:
sub r1, #(4 * (10))
^
armv6-m/arm_exception.S:139:2: note: instruction requires: thumb2
sub r1, #(4 * (10))
^
armv6-m/arm_exception.S:139:10: note: invalid operand for instruction
sub r1, #(4 * (10))
^
armv6-m/arm_exception.S:139:2: note: no flag-preserving variant of this instruction available
sub r1, #(4 * (10))
^
armv6-m/arm_exception.S:139:10: note: operand must be a register in range [r0, r7]
sub r1, #(4 * (10))
^
```
```
bringup.c:125:18: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
return ret;
^~~
bringup.c:73:10: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
```
## Impact
N/A
## Testing
CI check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7414: arch/armv6-m: fix compile error on LLVM clang
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7414:
URL: https://github.com/apache/incubator-nuttx/pull/7414#discussion_r1003206207
##########
boards/arm/phy62xx/phy6222/src/bringup.c:
##########
@@ -70,7 +70,7 @@ extern int phyplus_timer_initialize(const char *devpath, int timer);
int phy62xx_bringup(void)
{
- int ret;
+ int ret = OK;
Review Comment:
Let's remove `UNUSED(ret);` and update return to `return ret;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7414: arch/armv6-m: fix compile error on LLVM clang
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7414:
URL: https://github.com/apache/incubator-nuttx/pull/7414#discussion_r1003233917
##########
boards/arm/phy62xx/phy6222/src/bringup.c:
##########
@@ -70,7 +70,7 @@ extern int phyplus_timer_initialize(const char *devpath, int timer);
int phy62xx_bringup(void)
{
- int ret;
+ int ret = OK;
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7414: arch/armv6-m: fix compile error on LLVM clang
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7414:
URL: https://github.com/apache/incubator-nuttx/pull/7414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org