[GitHub] spark pull request #22677: [SPARK-25683][Core] Make AsyncEventQueue.lastRepo...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22677#discussion_r223849070
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
    @@ -159,6 +159,11 @@ private class AsyncEventQueue(
     
         val droppedCount = droppedEventsCounter.get
         if (droppedCount > 0) {
    +      // If first time the dropEvent occurs, then record current time as the
    +      // lastReportTimestamp.
    +      if (lastReportTimestamp == 0) {
    +        lastReportTimestamp = System.currentTimeMillis()
    --- End diff --
    
    @shivusondur 
    According to line 163, this seems to drop the first log completely.
    Could you add some test case for your PR?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org