[GitHub] [superset] villebro commented on a diff in pull request #24266: chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #24266:
URL: https://github.com/apache/superset/pull/24266#discussion_r1223983225


##########
tests/integration_tests/datasets/api_tests.py:
##########
@@ -348,7 +348,7 @@ def test_get_dataset_item(self):
             "sql": None,
             "table_name": "energy_usage",
             "template_params": None,
-            "uid": "2__table",
+            "uid": "6__table",

Review Comment:
   Since we're only asserting fields that are listed here (see lines 375-377), maybe we can just remove this line? I'm not sure we really need to assert the `uid`, as I assume doing this assertion will fail when running this test in isolation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org