You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 07:14:15 UTC

[GitHub] [pulsar] poorbarcode opened a new pull request, #17504: [branch-2.10][fix][flaky-test]ManagedCursorMetricsTest.testManagedCursorMetrics

poorbarcode opened a new pull request, #17504:
URL: https://github.com/apache/pulsar/pull/17504

   Fixes 
   - #9919
   
   ### Motivation & Modifications
   
   PR #16878 cannot be `cherry-picked` to `branch-2.10`, there will be a conflict. so create this new PR.
   
   ----
   
   (<strong>High light</strong>) The logic differs from #16878:
   
   -  after cursor init: metrics `brk_ml_cursor_persistLedgerSucceed` is `0` in `branch-master`. But in current PR, it is `1`
   
   "createNewMetadataLedger" triggers once BK writes
   
   - in `branch-2.10`, "cursor.initialize" triggers the execution of "createNewMetadataLedger". see <strong>[Code in branch-2.10]</strong>
   - in `branch-master`, "cursor.initialize" does not triggers the execution of "createNewMetadataLedger". see <strong>[Code in branch-master]</strong>
   
   
   
   #### Code in branch-2.10 (High light line: L651)
   
   https://github.com/apache/pulsar/blob/8409652f82b291891fe2670cfef3b869ad264a5a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L643-L663
   
   
   #### Code in branch-master (High light line: L653)
   
   https://github.com/apache/pulsar/blob/f453e0a5b7a57c2fdfeabc3f2d8778cc70dbc16a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L646-L665
   
   
   
   ### Documentation
   
   - [ ] `doc-required` 
     
   - [ ] `doc-not-needed` 
     
   - [ ] `doc` 
   
   - [ ] `doc-complete`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed pull request #17504: [branch-2.10][fix][flaky-test]ManagedCursorMetricsTest.testManagedCursorMetrics

Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #17504: [branch-2.10][fix][flaky-test]ManagedCursorMetricsTest.testManagedCursorMetrics
URL: https://github.com/apache/pulsar/pull/17504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #17504: [branch-2.10][fix][flaky-test]ManagedCursorMetricsTest.testManagedCursorMetrics

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17504:
URL: https://github.com/apache/pulsar/pull/17504#issuecomment-1240066260

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun merged pull request #17504: [branch-2.10][fix][flaky-test] ManagedCursorMetricsTest.testManagedCursorMetrics

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #17504:
URL: https://github.com/apache/pulsar/pull/17504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #17504: [branch-2.10][fix][flaky-test]ManagedCursorMetricsTest.testManagedCursorMetrics

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17504:
URL: https://github.com/apache/pulsar/pull/17504#issuecomment-1240988315

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #17504: [branch-2.10][fix][flaky-test]ManagedCursorMetricsTest.testManagedCursorMetrics

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17504:
URL: https://github.com/apache/pulsar/pull/17504#issuecomment-1289885324

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org