You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/01/30 19:47:49 UTC
[kudu-CR] KUDU-2680: ignore tombstones when updating dirs
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12313
to review the following change.
Change subject: KUDU-2680: ignore tombstones when updating dirs
......................................................................
KUDU-2680: ignore tombstones when updating dirs
Previously, when run without the --force configuration, the update_dirs
tool would fail upon meeting a tombstoned tablet. This is because
tombstones don't persist data dir groups, nor do they create them
in-memory upon loading; and the update_dirs tool uses the existence of
an in-memory data dir group to determine whether all tablets would be
considered healthy while staging a new directory configuration.
Since we don't expect tombstones to have data dir groups anyway, we
shouldn't be gating update_dirs on them not having data dir groups.
Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_fs.cc
2 files changed, 45 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/12313/1
--
To view, visit http://gerrit.cloudera.org:8080/12313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
Gerrit-Change-Number: 12313
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] KUDU-2680: ignore tombstones when updating dirs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12313 )
Change subject: KUDU-2680: ignore tombstones when updating dirs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
Gerrit-Change-Number: 12313
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Jan 2019 20:45:27 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2680: ignore tombstones when updating dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12313 )
Change subject: KUDU-2680: ignore tombstones when updating dirs
......................................................................
KUDU-2680: ignore tombstones when updating dirs
Previously, when run without the --force configuration, the update_dirs
tool would fail upon meeting a tombstoned tablet. This is because
tombstones don't persist data dir groups, nor do they create them
in-memory upon loading; and the update_dirs tool uses the existence of
an in-memory data dir group to determine whether all tablets would be
considered healthy while staging a new directory configuration.
Since we don't expect tombstones to have data dir groups anyway, we
shouldn't be gating update_dirs on them not having data dir groups.
Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
Reviewed-on: http://gerrit.cloudera.org:8080/12313
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_fs.cc
2 files changed, 47 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
Gerrit-Change-Number: 12313
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2680: ignore tombstones when updating dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12313
to look at the new patch set (#2).
Change subject: KUDU-2680: ignore tombstones when updating dirs
......................................................................
KUDU-2680: ignore tombstones when updating dirs
Previously, when run without the --force configuration, the update_dirs
tool would fail upon meeting a tombstoned tablet. This is because
tombstones don't persist data dir groups, nor do they create them
in-memory upon loading; and the update_dirs tool uses the existence of
an in-memory data dir group to determine whether all tablets would be
considered healthy while staging a new directory configuration.
Since we don't expect tombstones to have data dir groups anyway, we
shouldn't be gating update_dirs on them not having data dir groups.
Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_fs.cc
2 files changed, 47 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/12313/2
--
To view, visit http://gerrit.cloudera.org:8080/12313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
Gerrit-Change-Number: 12313
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2680: ignore tombstones when updating dirs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12313 )
Change subject: KUDU-2680: ignore tombstones when updating dirs
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12313/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12313/1/src/kudu/tools/kudu-tool-test.cc@3541
PS1, Line 3541: NO_FATALS(RunActionStdoutNone(Substitute(
Maybe add a comment saying something like "remove one data directory; the tombstone tablet should not prevent that from happening" or some such.
--
To view, visit http://gerrit.cloudera.org:8080/12313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
Gerrit-Change-Number: 12313
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Jan 2019 20:02:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2680: ignore tombstones when updating dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12313 )
Change subject: KUDU-2680: ignore tombstones when updating dirs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12313/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12313/1/src/kudu/tools/kudu-tool-test.cc@3541
PS1, Line 3541: // KUDU-2680: tombstones shouldn't prevent us from removing a directory.
> Maybe add a comment saying something like "remove one data directory; the t
Done
--
To view, visit http://gerrit.cloudera.org:8080/12313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If39ec768e9328571adc3ed0ef69c6a9309f27989
Gerrit-Change-Number: 12313
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Jan 2019 20:30:33 +0000
Gerrit-HasComments: Yes