You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/10 16:23:53 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #8222:
github action tests
potiuk commented on a change in pull request #8222: github action tests
URL: https://github.com/apache/airflow/pull/8222#discussion_r406829365
##########
File path: scripts/ci/ci_run_airflow_testing.sh
##########
@@ -79,36 +79,3 @@ done
RUN_INTEGRATION_TESTS=${RUN_INTEGRATION_TESTS:=""}
-if [[ ${RUNTIME:=} == "kubernetes" ]]; then
- export KUBERNETES_MODE=${KUBERNETES_MODE:="git_mode"}
- export KUBERNETES_VERSION=${KUBERNETES_VERSION:="v1.15.3"}
-
- set +u
- # shellcheck disable=SC2016
- docker-compose --log-level INFO \
- -f "${MY_DIR}/docker-compose/base.yml" \
- -f "${MY_DIR}/docker-compose/backend-${BACKEND}.yml" \
- -f "${MY_DIR}/docker-compose/runtime-kubernetes.yml" \
- "${INTEGRATIONS[@]}" \
- "${DOCKER_COMPOSE_LOCAL[@]}" \
- run airflow \
- '/opt/airflow/scripts/ci/in_container/entrypoint_ci.sh "${@}"' \
- /opt/airflow/scripts/ci/in_container/entrypoint_ci.sh "${@}"
- # Note the command is there twice (!) because it is passed via bash -c
- # and bash -c starts passing parameters from $0. TODO: fixme
- set -u
-else
- set +u
- # shellcheck disable=SC2016
- docker-compose --log-level INFO \
- -f "${MY_DIR}/docker-compose/base.yml" \
- -f "${MY_DIR}/docker-compose/backend-${BACKEND}.yml" \
- "${INTEGRATIONS[@]}" \
- "${DOCKER_COMPOSE_LOCAL[@]}" \
- run airflow \
- '/opt/airflow/scripts/ci/in_container/entrypoint_ci.sh "${@}"' \
- /opt/airflow/scripts/ci/in_container/entrypoint_ci.sh "${@}"
- # Note the command is there twice (!) because it is passed via bash -c
- # and bash -c starts passing parameters from $0. TODO: fixme
- set -u
Review comment:
We definitely need the else. all tests are using it but the kubernetes ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services