You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/22 19:17:45 UTC
[GitHub] [spark] tanelk opened a new pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
tanelk opened a new pull request #29842:
URL: https://github.com/apache/spark/pull/29842
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Change the parameter valus in the UT for SPARK-32019 (#28853)
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The runtime of this one UT can be over 7 minutes on Jenkins. After the change it is few seconds.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700079488
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33804/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696929279
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699820393
Could you describe what's a root cause of the slow tests and how-to-fix in the PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700041950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r495878125
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -529,37 +529,42 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
}
test("SPARK-32019: Add spark.sql.files.minPartitionNum config") {
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
- val table =
- createTable(files = Seq(
- "file1" -> 1,
- "file2" -> 1,
- "file3" -> 1
- ))
- assert(table.rdd.partitions.length == 1)
- }
+ withSQLConf(
+ SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB",
+ SQLConf.FILES_OPEN_COST_IN_BYTES.key -> String.valueOf(4 * 1024 * 1024)) {
+
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
Review comment:
I think it is okay just to update the slow two tests only in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r495985585
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -549,17 +549,22 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
assert(table.rdd.partitions.length == 3)
}
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "16") {
- val partitions = (1 to 100).map(i => s"file$i" -> 128 * 1024 * 1024)
- val table = createTable(files = partitions)
- // partition is limited by filesMaxPartitionBytes(128MB)
- assert(table.rdd.partitions.length == 100)
- }
+ withSQLConf(
+ SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB",
+ SQLConf.FILES_OPEN_COST_IN_BYTES.key -> String.valueOf(4 * 1024 * 1024)) {
+
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "8") {
+ val partitions = (1 to 12).map(i => s"file$i" -> 2 * 1024 * 1024)
+ val table = createTable(files = partitions)
+ // partition is limited by filesMaxPartitionBytes(2MB)
+ assert(table.rdd.partitions.length == 12)
+ }
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "32") {
- val partitions = (1 to 800).map(i => s"file$i" -> 4 * 1024 * 1024)
- val table = createTable(files = partitions)
- assert(table.rdd.partitions.length == 50)
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "8") {
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700053498
**[Test build #129189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129189/testReport)** for PR 29842 at commit [`42020ee`](https://github.com/apache/spark/commit/42020eed50f0e01da0a4827616427904134d1eca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699867630
> Could you describe what's a root cause of the slow tests and how-to-fix in the PR description?
I tried to explain it a bit better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-697035911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-697035580
**[Test build #128997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128997/testReport)** for PR 29842 at commit [`45dee3f`](https://github.com/apache/spark/commit/45dee3f93dc270e2035c3b0e92be8542b38b47a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700195340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29842:
URL: https://github.com/apache/spark/pull/29842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696927929
@ulysses-you, you were the original author, could you check if the test coverage is the same
@dongjoon-hyun and @cloud-fan you requested the extra tests in the original PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700053498
**[Test build #129189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129189/testReport)** for PR 29842 at commit [`42020ee`](https://github.com/apache/spark/commit/42020eed50f0e01da0a4827616427904134d1eca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699073695
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33739/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r493104670
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -529,37 +529,39 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
}
test("SPARK-32019: Add spark.sql.files.minPartitionNum config") {
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
- val table =
- createTable(files = Seq(
- "file1" -> 1,
- "file2" -> 1,
- "file3" -> 1
- ))
- assert(table.rdd.partitions.length == 1)
- }
+ withSQLConf(SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB") {
Review comment:
Can we add the config `spark.sql.files.openCostInBytes` ? The result is based on it although we don't change the default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-697034887
add to whitelist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699171283
**[Test build #129120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129120/testReport)** for PR 29842 at commit [`d71ad45`](https://github.com/apache/spark/commit/d71ad4503f521c9868cfe298aaab8e2dd7b3cf7c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696929915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700224587
**[Test build #129189 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129189/testReport)** for PR 29842 at commit [`42020ee`](https://github.com/apache/spark/commit/42020eed50f0e01da0a4827616427904134d1eca).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-697034887
add to whitelist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696929279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r495932535
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -529,37 +529,42 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
}
test("SPARK-32019: Add spark.sql.files.minPartitionNum config") {
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
- val table =
- createTable(files = Seq(
- "file1" -> 1,
- "file2" -> 1,
- "file3" -> 1
- ))
- assert(table.rdd.partitions.length == 1)
- }
+ withSQLConf(
+ SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB",
+ SQLConf.FILES_OPEN_COST_IN_BYTES.key -> String.valueOf(4 * 1024 * 1024)) {
+
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700030920
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33801/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696929279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r495129043
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -529,37 +529,39 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
}
test("SPARK-32019: Add spark.sql.files.minPartitionNum config") {
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
- val table =
- createTable(files = Seq(
- "file1" -> 1,
- "file2" -> 1,
- "file3" -> 1
- ))
- assert(table.rdd.partitions.length == 1)
- }
+ withSQLConf(SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB") {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696927929
@ulysses-you, you were the original author, could you check if the test coverage is the same
@dongjoon-hyun and @cloud-fan you requested the extra tests in the original PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699081950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700194112
**[Test build #129188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129188/testReport)** for PR 29842 at commit [`4f386f4`](https://github.com/apache/spark/commit/4f386f45e744b8cc412f7198666ec17fc0004525).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696929915
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699056795
**[Test build #129120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129120/testReport)** for PR 29842 at commit [`d71ad45`](https://github.com/apache/spark/commit/d71ad4503f521c9868cfe298aaab8e2dd7b3cf7c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700226055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699056795
**[Test build #129120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129120/testReport)** for PR 29842 at commit [`d71ad45`](https://github.com/apache/spark/commit/d71ad4503f521c9868cfe298aaab8e2dd7b3cf7c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700518083
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700041950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700012255
**[Test build #129188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129188/testReport)** for PR 29842 at commit [`4f386f4`](https://github.com/apache/spark/commit/4f386f45e744b8cc412f7198666ec17fc0004525).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700012255
**[Test build #129188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129188/testReport)** for PR 29842 at commit [`4f386f4`](https://github.com/apache/spark/commit/4f386f45e744b8cc412f7198666ec17fc0004525).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700120844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699171973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700120824
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33804/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699171973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700041915
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33801/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-697035580
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r495965135
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -549,17 +549,22 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
assert(table.rdd.partitions.length == 3)
}
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "16") {
- val partitions = (1 to 100).map(i => s"file$i" -> 128 * 1024 * 1024)
- val table = createTable(files = partitions)
- // partition is limited by filesMaxPartitionBytes(128MB)
- assert(table.rdd.partitions.length == 100)
- }
+ withSQLConf(
+ SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB",
+ SQLConf.FILES_OPEN_COST_IN_BYTES.key -> String.valueOf(4 * 1024 * 1024)) {
+
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "8") {
+ val partitions = (1 to 12).map(i => s"file$i" -> 2 * 1024 * 1024)
+ val table = createTable(files = partitions)
+ // partition is limited by filesMaxPartitionBytes(2MB)
+ assert(table.rdd.partitions.length == 12)
+ }
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "32") {
- val partitions = (1 to 800).map(i => s"file$i" -> 4 * 1024 * 1024)
- val table = createTable(files = partitions)
- assert(table.rdd.partitions.length == 50)
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "8") {
Review comment:
`8` -> `16` for keeping the original test context?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700226055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-696929279
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r493104670
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -529,37 +529,39 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
}
test("SPARK-32019: Add spark.sql.files.minPartitionNum config") {
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
- val table =
- createTable(files = Seq(
- "file1" -> 1,
- "file2" -> 1,
- "file3" -> 1
- ))
- assert(table.rdd.partitions.length == 1)
- }
+ withSQLConf(SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB") {
Review comment:
Can we add the config `spark.sql.files.openCostInBytes` ? The result is based on it although we don't change the default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700195340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699081950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-697035580
**[Test build #128997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128997/testReport)** for PR 29842 at commit [`45dee3f`](https://github.com/apache/spark/commit/45dee3f93dc270e2035c3b0e92be8542b38b47a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-699081930
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33739/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29842:
URL: https://github.com/apache/spark/pull/29842#issuecomment-700120844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org