You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/17 08:48:38 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#4339: extract interface for center repository and polish properties
processing
kimmking opened a new pull request #4339: extract interface for center repository and polish properties processing
URL: https://github.com/apache/incubator-shardingsphere/pull/4339
Changes proposed in this pull request:
- extract interface for center repository
- polish properties processing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4339: extract interface for center repository and polish properties
processing
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4339: extract interface for center repository and polish properties processing
URL: https://github.com/apache/incubator-shardingsphere/pull/4339#issuecomment-586893926
## Pull Request Test Coverage Report for [Build 9594](https://coveralls.io/builds/28769749)
* **5** of **6** **(83.33%)** changed or added relevant lines in **2** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **57.681%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28769749/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L60) | 0 | 1 | 0.0%
<!-- | **Total:** | **5** | **6** | **83.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28769749/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28769749) |
| :-- | --: |
| Change from base [Build 869](https://coveralls.io/builds/28759465): | -0.005% |
| Covered Lines: | 11084 |
| Relevant Lines: | 19216 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4339:
extract interface for center repository and polish properties processing
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4339: extract interface for center repository and polish properties processing
URL: https://github.com/apache/incubator-shardingsphere/pull/4339#issuecomment-586893926
## Pull Request Test Coverage Report for [Build 1768](https://coveralls.io/builds/28769758)
* **5** of **6** **(83.33%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.686%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28769758/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L60) | 0 | 1 | 0.0%
<!-- | **Total:** | **5** | **6** | **83.33%** | -->
| Totals | [](https://coveralls.io/builds/28769758) |
| :-- | --: |
| Change from base [Build 869](https://coveralls.io/builds/28759465): | 0.0% |
| Covered Lines: | 11085 |
| Relevant Lines: | 19216 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4339:
extract interface for center repository and polish properties processing
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4339: extract interface for center repository and polish properties processing
URL: https://github.com/apache/incubator-shardingsphere/pull/4339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4339:
extract interface for center repository and polish properties processing
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4339: extract interface for center repository and polish properties processing
URL: https://github.com/apache/incubator-shardingsphere/pull/4339#issuecomment-586893277
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3b6a360`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4339 +/- ##
=========================================
Coverage ? 54.22%
Complexity ? 352
=========================================
Files ? 1045
Lines ? 19216
Branches ? 3531
=========================================
Hits ? 10419
Misses ? 8142
Partials ? 655
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `54.05% <0%> (ø)` | `0 <0> (?)` | |
| [...tion/center/instance/CuratorZookeeperInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckluc3RhbmNlLmphdmE=) | `40.79% <100%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339?src=pr&el=footer). Last update [3b6a360...2f3acd8](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4339?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services