You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/02/02 11:28:39 UTC

Re: Review Request 42633: Corrected a comment in the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42633/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 10:28 a.m.)


Review request for mesos, Ben Mahler and Qian Zhang.


Repository: mesos


Description
-------

Revocable resources may come from different sources: usage slack (aka
oversubscribed resources), allocation slack (aka optimistic offers).
We should not use "oversubscribed" and "revocable" interchangeably.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 1f0c440565ee0f9926d168734df30fd740a53f88 

Diff: https://reviews.apache.org/r/42633/diff/


Testing
-------

None: not a functional change.


Thanks,

Alexander Rukletsov

Re: Review Request 42633: Corrected a comment in the allocator.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42633/#review118416
-----------------------------------------------------------


Ship it!




Ship It!

- Ben Mahler


On Feb. 2, 2016, 10:28 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42633/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Revocable resources may come from different sources: usage slack (aka
> oversubscribed resources), allocation slack (aka optimistic offers).
> We should not use "oversubscribed" and "revocable" interchangeably.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 1f0c440565ee0f9926d168734df30fd740a53f88 
> 
> Diff: https://reviews.apache.org/r/42633/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>