You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/10/02 14:31:13 UTC
[PR] fix(message): trim the custom trace topic in the manual trace query [rocketmq-dashboard]
tju-yxq opened a new pull request, #5402:
URL: https://github.com/apache/rocketmq-dashboard/pull/5402
### Which Issue(s) This PR Fixes
- Fixes #5401
### Brief Description
`runTraceQuery` passed the custom trace topic to both trace APIs raw; it now trims it first (`normalizedTraceTopic`), mirroring `loadMessageTrace`, which already normalizes before both the cache key and the request. The query value itself was already trimmed; only the topic argument was left raw. Persistence and history replay were already trimming — this closes the last untrimmed path for the field.
### How Did You Test This Change?
```
cd web && npm test -- MessagePageAsyncState.test.tsx --run
Test Files 1 passed (1)
Tests 23 passed (23)
```
One new test mirrors the existing manual key-trace test but types ` CUSTOM_TRACE ` (padded) and asserts `getMessageTraceByKey` receives `CUSTOM_TRACE` — the value every other path for the field already produces. The 22 existing tests (lazy trace loads, cache reuse, per-instance topic persistence, history replay, stale-response guards) pass unchanged.
```
cd web && npm run lint
✖ 10 problems (0 errors, 10 warnings) # the trunk baseline
```
```
cd web && npx tsc -b --force
(no output — exit 0)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named `...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/` (no new UI text)
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit checks) (no Java changes)
- [x] New source files carry the ASF license header (no new source files)
- [ ] Documentation touched where behaviour changed (normalization fix only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(message): trim the custom trace topic in the manual trace query [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5402:
URL: https://github.com/apache/rocketmq-dashboard/pull/5402#issuecomment-6091520099
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(message): trim the custom trace topic in the manual trace query [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5402: fix(message): trim the custom trace topic in the manual trace query
URL: https://github.com/apache/rocketmq-dashboard/pull/5402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org