You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/24 14:34:46 UTC

[GitHub] [flink] aljoscha commented on a change in pull request #12987: [FLINK-18703][table] Use new data structure converters when legacy types are not present

aljoscha commented on a change in pull request #12987:
URL: https://github.com/apache/flink/pull/12987#discussion_r460091224



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/SinkCodeGenerator.scala
##########
@@ -102,7 +102,8 @@ object SinkCodeGenerator {
     }
 
     val consumedDataType = sink.getConsumedDataType
-    val outTerm = genToExternal(ctx, physicalOutputType, afterIndexModify)
+    // still uses the old conversion stack due to FLINK-18701

Review comment:
       We will merge this as is without first adressing FLINK-18701?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org