You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by dp...@apache.org on 2018/11/29 11:34:57 UTC

[ignite-teamcity-bot] branch ignite-9542-new-run-stripe updated: IGNITE-9542 Querying of run history implemented for all branches

This is an automated email from the ASF dual-hosted git repository.

dpavlov pushed a commit to branch ignite-9542-new-run-stripe
in repository https://gitbox.apache.org/repos/asf/ignite-teamcity-bot.git


The following commit(s) were added to refs/heads/ignite-9542-new-run-stripe by this push:
     new da22d3e  IGNITE-9542 Querying of run history implemented for all branches
da22d3e is described below

commit da22d3e1f29f7b0412b8f6e91066acd2e5596cde
Author: Dmitriy Pavlov <dp...@apache.org>
AuthorDate: Thu Nov 29 14:34:54 2018 +0300

    IGNITE-9542 Querying of run history implemented for all branches
---
 .../ignite/ci/teamcity/ignited/IRunHistory.java    | 29 ++----------
 .../ignited/{IRunHistory.java => IRunStat.java}    | 53 +++-------------------
 .../ci/teamcity/ignited/ITeamcityIgnited.java      | 12 +++--
 .../ci/teamcity/ignited/TeamcityIgnitedImpl.java   |  8 ++++
 .../teamcity/ignited/runhist/InvocationData.java   |  2 +-
 .../teamcity/ignited/runhist/RunHistCompacted.java | 22 ++-------
 .../ignited/runhist/RunHistCompactedDao.java       | 41 +++++++++++++++--
 .../ci/teamcity/ignited/runhist/RunHistKey.java    | 25 +++++++---
 .../ci/teamcity/ignited/runhist/RunHistSync.java   |  5 +-
 .../ci/tcbot/chain/PrChainsProcessorTest.java      | 28 ++++++++++--
 .../ignited/IgnitedTcInMemoryIntegrationTest.java  |  9 ++++
 .../ci/teamcity/ignited/TeamcityIgnitedMock.java   |  3 +-
 12 files changed, 121 insertions(+), 116 deletions(-)

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunHistory.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunHistory.java
index 5f27621..091d8f7 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunHistory.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunHistory.java
@@ -22,20 +22,8 @@ import java.util.List;
 /**
  * Test or Build run statistics.
  */
-public interface IRunHistory {
-    public int getRunsCount();
-    public int getFailuresCount();
-
-    public static String getPercentPrintable(float percent) {
-        return String.format("%.1f", percent).replace(".", ",");
-    }
-
-    public default String getFailPercentPrintable() {
-        return getPercentPrintable(getFailRate() * 100.0f);
-    }
-
+public interface IRunHistory extends IRunStat {
     public int getFailuresAllHist();
-
     public int getRunsAllHist();
 
     public default float getFailRateAllHist() {
@@ -46,20 +34,9 @@ public interface IRunHistory {
     }
 
     public default String getFailPercentAllHistPrintable() {
-        return getPercentPrintable(getFailRateAllHist() * 100.0f);
+        return IRunStat.getPercentPrintable(getFailRateAllHist() * 100.0f);
     }
 
-    /**
-     * @return fail rate as float.
-     */
-    public default float getFailRate() {
-        int runs = getRunsCount();
-
-        if (runs == 0)
-            return 0.0f;
-
-        return 1.0f * getFailuresCount() / runs;
-    }
 
     @Nullable
     List<Integer> getLatestRunResults();
@@ -67,7 +44,7 @@ public interface IRunHistory {
     String getFlakyComments();
 
     public default String getCriticalFailPercentPrintable() {
-        return IRunHistory.getPercentPrintable(getCriticalFailRate() * 100.0f);
+        return IRunStat.getPercentPrintable(getCriticalFailRate() * 100.0f);
     }
 
     /**
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunHistory.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunStat.java
similarity index 57%
copy from ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunHistory.java
copy to ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunStat.java
index 5f27621..34ddf36 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunHistory.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/IRunStat.java
@@ -16,39 +16,13 @@
  */
 package org.apache.ignite.ci.teamcity.ignited;
 
-import javax.annotation.Nullable;
-import java.util.List;
-
 /**
- * Test or Build run statistics.
+ * Abstract runs statistics,
  */
-public interface IRunHistory {
+public interface IRunStat {
     public int getRunsCount();
     public int getFailuresCount();
 
-    public static String getPercentPrintable(float percent) {
-        return String.format("%.1f", percent).replace(".", ",");
-    }
-
-    public default String getFailPercentPrintable() {
-        return getPercentPrintable(getFailRate() * 100.0f);
-    }
-
-    public int getFailuresAllHist();
-
-    public int getRunsAllHist();
-
-    public default float getFailRateAllHist() {
-        if (getRunsAllHist() == 0)
-            return 0.0f;
-
-        return 1.0f * getFailuresAllHist() / getRunsAllHist();
-    }
-
-    public default String getFailPercentAllHistPrintable() {
-        return getPercentPrintable(getFailRateAllHist() * 100.0f);
-    }
-
     /**
      * @return fail rate as float.
      */
@@ -61,27 +35,12 @@ public interface IRunHistory {
         return 1.0f * getFailuresCount() / runs;
     }
 
-    @Nullable
-    List<Integer> getLatestRunResults();
-
-    String getFlakyComments();
-
-    public default String getCriticalFailPercentPrintable() {
-        return IRunHistory.getPercentPrintable(getCriticalFailRate() * 100.0f);
+    public default String getFailPercentPrintable() {
+        return getPercentPrintable(getFailRate() * 100.0f);
     }
 
-    /**
-     * @return float representing fail rate
-     */
-    public default float getCriticalFailRate() {
-        int runs = getRunsCount();
-
-        if (runs == 0)
-            return 1.0f;
 
-        return 1.0f * getCriticalFailuresCount() / runs;
+    public static String getPercentPrintable(float percent) {
+        return String.format("%.1f", percent).replace(".", ",");
     }
-
-
-    public int getCriticalFailuresCount();
 }
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/ITeamcityIgnited.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/ITeamcityIgnited.java
index dd4896d..e8486d5 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/ITeamcityIgnited.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/ITeamcityIgnited.java
@@ -126,9 +126,13 @@ public interface ITeamcityIgnited {
      */
     @NotNull public List<Integer> getLastNBuildsFromHistory(String btId, String branchForTc, int cnt);
 
-    @Nullable
-    IRunHistory getTestRunHist(TestInBranch testInBranch);
+    @Nullable public IRunHistory getTestRunHist(TestInBranch testInBranch);
 
-    @Nullable
-    IRunHistory getSuiteRunHist(SuiteInBranch branch);
+    @Nullable public IRunHistory getSuiteRunHist(SuiteInBranch branch);
+
+    /**
+     * @param suiteBuildTypeId Suite id.
+     * @return run statistics of recent runls on all branches.
+     */
+    @Nullable public IRunStat getSuiteRunStatAllBranches(String suiteBuildTypeId);
 }
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedImpl.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedImpl.java
index a6faceb..d5f139b 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedImpl.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedImpl.java
@@ -331,6 +331,14 @@ public class TeamcityIgnitedImpl implements ITeamcityIgnited {
         return runHistCompactedDao.getSuiteRunHist(srvIdMaskHigh, suiteInBranch.getSuiteId(), suiteInBranch.branch);
     }
 
+    /** {@inheritDoc} */
+    @Nullable @Override public IRunStat getSuiteRunStatAllBranches(String suiteBuildTypeId) {
+        return runHistCompactedDao.getSuiteRunStatAllBranches(srvIdMaskHigh, suiteBuildTypeId);
+    }
+
+    /**
+     * @param branchName Branch name.
+     */
     public List<String> branchForQuery(@Nullable String branchName) {
         if (ITeamcity.DEFAULT.equals(branchName))
             return Lists.newArrayList(branchName, ITeamcity.REFS_HEADS_MASTER, "master");
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/InvocationData.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/InvocationData.java
index bb0e6af..7ccc0fa 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/InvocationData.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/InvocationData.java
@@ -58,7 +58,7 @@ public class InvocationData {
         return allHistRuns;
     }
 
-    public boolean add(Invocation inv) {
+    public boolean addInvocation(Invocation inv) {
         try {
             return innerAdd(inv);
         }
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompacted.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompacted.java
index 9f25030..df99447 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompacted.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompacted.java
@@ -39,19 +39,12 @@ public class RunHistCompacted implements IVersionedEntity, IRunHistory {
     @SuppressWarnings("FieldCanBeLocal")
     private short _ver = LATEST_VERSION;
 
-    @QuerySqlField(orderedGroups = {@QuerySqlField.Group(name = "tstAndSrv", order = 0)})
-    private int testOrSuiteName;
-
-    @QuerySqlField(orderedGroups = {@QuerySqlField.Group(name = "tstAndSrv", order = 1)})
-    private int srvId;
-
     private InvocationData data = new InvocationData();
 
     public RunHistCompacted() {}
 
-    public RunHistCompacted(RunHistKey k) {
-        testOrSuiteName = k.testNameOrSuite();
-        srvId = k.srvId();
+    public RunHistCompacted(RunHistKey ignored) {
+
     }
 
     /** {@inheritDoc} */
@@ -99,19 +92,16 @@ public class RunHistCompacted implements IVersionedEntity, IRunHistory {
     }
 
     /**
-     * @param build Build.
      * @param inv Invocation.
      * @return if test run is new and is not expired.
      */
-    public boolean addTestRun(int build, Invocation inv) {
-        return data.add(inv);
+    public boolean addInvocation(Invocation inv) {
+        return data.addInvocation(inv);
     }
 
     /** {@inheritDoc} */
     @Override public String toString() {
         return MoreObjects.toStringHelper(this)
-                .add("nameId", testOrSuiteName)
-                .add("srvId", srvId)
                 .add("failRate", getFailPercentPrintable())
                 .add("data", data)
                 .toString();
@@ -125,13 +115,11 @@ public class RunHistCompacted implements IVersionedEntity, IRunHistory {
             return false;
         RunHistCompacted compacted = (RunHistCompacted)o;
         return _ver == compacted._ver &&
-            testOrSuiteName == compacted.testOrSuiteName &&
-            srvId == compacted.srvId &&
             Objects.equal(data, compacted.data);
     }
 
     /** {@inheritDoc} */
     @Override public int hashCode() {
-        return Objects.hashCode(_ver, testOrSuiteName, srvId, data);
+        return Objects.hashCode(_ver, data);
     }
 }
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompactedDao.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompactedDao.java
index 51f614f..3445254 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompactedDao.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistCompactedDao.java
@@ -18,13 +18,18 @@
 package org.apache.ignite.ci.teamcity.ignited.runhist;
 
 import java.util.List;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.cache.Cache;
 import javax.cache.processor.MutableEntry;
 import org.apache.ignite.Ignite;
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.cache.QueryEntity;
+import org.apache.ignite.cache.query.QueryCursor;
+import org.apache.ignite.cache.query.SqlQuery;
 import org.apache.ignite.ci.db.TcHelperDb;
 import org.apache.ignite.ci.di.AutoProfiling;
 import org.apache.ignite.ci.teamcity.ignited.IRunHistory;
+import org.apache.ignite.ci.teamcity.ignited.IRunStat;
 import org.apache.ignite.ci.teamcity.ignited.IStringCompactor;
 import org.apache.ignite.configuration.CacheConfiguration;
 
@@ -157,11 +162,7 @@ public class RunHistCompactedDao {
         List<Invocation> invocationList = (List<Invocation>)parms[0];
 
         for (Invocation invocation : invocationList) {
-            boolean added = hist.addTestRun(
-                invocation.buildId(),
-                invocation);
-
-            if (added)
+            if (hist.addInvocation(invocation))
                 cnt++;
         }
 
@@ -183,4 +184,34 @@ public class RunHistCompactedDao {
 
         return suiteHistCacheName.get(key);
     }
+
+    public IRunStat getSuiteRunStatAllBranches(int srvIdMaskHigh, String btId) {
+        final Integer testName = compactor.getStringIdIfPresent(btId);
+        if (testName == null)
+            return null;
+
+        AtomicInteger runs = new AtomicInteger();
+        AtomicInteger failures = new AtomicInteger();
+        try (QueryCursor<Cache.Entry<RunHistKey, RunHistCompacted>> qryCursor = suiteHistCacheName.query(
+            new SqlQuery<RunHistKey, RunHistCompacted>(RunHistCompacted.class, "testOrSuiteName = ? and srvId=?")
+                .setArgs(testName, srvIdMaskHigh))) {
+
+            for (Cache.Entry<RunHistKey, RunHistCompacted> next : qryCursor) {
+                RunHistCompacted val = next.getValue();
+
+                runs.addAndGet(val.getRunsCount());
+                failures.addAndGet(val.getFailuresCount());
+            }
+        }
+
+        return new IRunStat() {
+            @Override public int getRunsCount() {
+                return runs.get();
+            }
+
+            @Override public int getFailuresCount() {
+                return failures.get();
+            }
+        };
+    }
 }
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistKey.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistKey.java
index 0c671ed..239e479 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistKey.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistKey.java
@@ -18,16 +18,21 @@
 package org.apache.ignite.ci.teamcity.ignited.runhist;
 
 import com.google.common.base.Objects;
+import org.apache.ignite.cache.query.annotations.QuerySqlField;
 
 /**
  *
  */
 public class RunHistKey {
-    /** Server id. */
+    /** Server ID. */
+    @QuerySqlField(orderedGroups = {@QuerySqlField.Group(name = "tstAndSrv", order = 1)})
     private int srvId;
-    /** Test name or suite. */
+
+    /** Test name or suite build type ID. */
+    @QuerySqlField(orderedGroups = {@QuerySqlField.Group(name = "tstAndSrv", order = 0)})
     private int testOrSuiteName;
-    /** Branch. */
+
+    /** Branch name. */
     private int branch;
 
     /**
@@ -41,8 +46,8 @@ public class RunHistKey {
         this.branch = branchName;
     }
 
-    @Override
-    public boolean equals(Object o) {
+    /** {@inheritDoc} */
+    @Override public boolean equals(Object o) {
         if (this == o) return true;
         if (o == null || getClass() != o.getClass()) return false;
         RunHistKey histKey = (RunHistKey) o;
@@ -51,15 +56,21 @@ public class RunHistKey {
                 branch == histKey.branch;
     }
 
-    @Override
-    public int hashCode() {
+    /** {@inheritDoc} */
+    @Override public int hashCode() {
         return Objects.hashCode(srvId, testOrSuiteName, branch);
     }
 
+    /**
+     *
+     */
     public int testNameOrSuite() {
         return testOrSuiteName;
     }
 
+    /**
+     *
+     */
     public int srvId() {
         return srvId;
     }
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistSync.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistSync.java
index 99d6ff2..05ba24e 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistSync.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/runhist/RunHistSync.java
@@ -181,9 +181,10 @@ public class RunHistSync {
         );
 
         buildsSaveThisRun.forEach(
-            (histKey,suiteList)->{
+            (histKey, suiteList) -> {
                 List<Invocation> invocationsToSave = suiteList.stream()
-                    .filter(invocation -> confirmedNewBuild.contains(invocation.buildId()))
+                    .filter(inv -> confirmedNewBuild.contains(inv.buildId()))
+                    .filter(inv -> !InvocationData.isExpired(inv.startDate()))
                     .collect(Collectors.toList());
 
                 Integer cntAdded = histDao.addSuiteInvocations(histKey, invocationsToSave);
diff --git a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java
index 963533e..77550d5 100644
--- a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java
+++ b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java
@@ -56,6 +56,7 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.mock;
@@ -180,7 +181,7 @@ public class PrChainsProcessorTest {
 
         childBuild.snapshotDependencies(new int[] {buildBuild.id()});
 
-        final Build build = createPassedBuild("CancelledBuild", branch, 1003, 100020);
+        final Build build = createJaxbBuild("CancelledBuild", branch, 1003, 100020, true);
 
         build.status = BuildRef.STATUS_UNKNOWN;
         build.state = BuildRef.STATE_FINISHED;
@@ -226,6 +227,20 @@ public class PrChainsProcessorTest {
                 .addTests(c, Lists.newArrayList(
                     createFailedTest(400L, TEST_WAS_FIXED_IN_MASTER))));
         }
+
+        for (int i = 0; i < 10; i++) {
+            final FatBuildCompacted successfull =
+                createFatBuild(c, CACHE_1, "some-exotic-branch", i+7777, 100020, true)
+                    .addTests(c,
+                        Lists.newArrayList(
+                            createPassingTest(1L, TEST_WITHOUT_HISTORY),
+                            createPassingTest(2L, TEST_WITH_HISTORY_FAILING_IN_MASTER),
+                            createPassingTest(3L, TEST_WITH_HISTORY_PASSING_IN_MASTER),
+                            createPassingTest(50L, TEST_FLAKY_IN_MASTER),
+                            createPassingTest(400L, TEST_WAS_FIXED_IN_MASTER)));
+
+            addBuilds(successfull);
+        }
     }
 
     private void addBuilds(FatBuildCompacted... builds) {
@@ -259,15 +274,18 @@ public class PrChainsProcessorTest {
 
     @NotNull
     public FatBuildCompacted createFailedBuild(IStringCompactor c, String btId, String branch, int id, long ageMs) {
-        final Build build = createPassedBuild(btId, branch, id, ageMs);
+        return createFatBuild(c, btId, branch, id, ageMs, false);
+    }
 
-        build.status = BuildRef.STATUS_FAILURE;
+    @NotNull public FatBuildCompacted createFatBuild(IStringCompactor c, String btId, String branch, int id, long ageMs,
+        boolean passed) {
+        final Build build = createJaxbBuild(btId, branch, id, ageMs, passed);
 
         return new FatBuildCompacted(c, build);
     }
 
     @NotNull
-    private Build createPassedBuild(String btId, String branch, int id, long ageMs) {
+    private Build createJaxbBuild(String btId, String branch, int id, long ageMs, boolean passed) {
         final Build build = new Build();
         build.buildTypeId = btId;
         final BuildType type = new BuildType();
@@ -278,7 +296,7 @@ public class PrChainsProcessorTest {
         build.setStartDateTs(System.currentTimeMillis() - ageMs);
         build.setBranchName(branch);
         build.state = Build.STATE_FINISHED;
-        build.status = Build.STATUS_SUCCESS;
+        build.status = passed ? Build.STATUS_SUCCESS : BuildRef.STATUS_FAILURE;
 
         return build;
     }
diff --git a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/IgnitedTcInMemoryIntegrationTest.java b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/IgnitedTcInMemoryIntegrationTest.java
index 632a6aa..1d7c835 100644
--- a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/IgnitedTcInMemoryIntegrationTest.java
+++ b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/IgnitedTcInMemoryIntegrationTest.java
@@ -375,6 +375,15 @@ public class IgnitedTcInMemoryIntegrationTest {
         assertNotNull(cache1Hist);
         assertEquals(1.0, cache1Hist.getFailRate(), 0.1);
         assertEquals(0.18, cache1Hist.getCriticalFailRate(), 0.05);
+
+        final IRunStat cache1HistAllBranch = srv.getSuiteRunStatAllBranches(PrChainsProcessorTest.CACHE_1);
+
+        assertNotNull(cache1HistAllBranch);
+
+        String printable = cache1HistAllBranch.getFailPercentPrintable();
+        System.err.println(printable);
+        // should be several builds in a separate branch
+        assertEquals(0.5, cache1HistAllBranch.getFailRate(), 0.05);
     }
 
 
diff --git a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedMock.java b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedMock.java
index eb62f2d..5754571 100644
--- a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedMock.java
+++ b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/teamcity/ignited/TeamcityIgnitedMock.java
@@ -19,7 +19,6 @@ package org.apache.ignite.ci.teamcity.ignited;
 
 import com.google.common.base.Preconditions;
 import org.apache.ignite.ci.analysis.TestInBranch;
-import org.apache.ignite.ci.tcmodel.result.tests.TestOccurrence;
 import org.apache.ignite.ci.teamcity.ignited.fatbuild.FatBuildCompacted;
 import org.apache.ignite.ci.teamcity.ignited.runhist.Invocation;
 import org.apache.ignite.ci.teamcity.ignited.runhist.RunHistCompacted;
@@ -134,7 +133,7 @@ public class TeamcityIgnitedMock {
 
                 Invocation inv = t.toInvocation(c, build);
 
-                hist.addTestRun(build.id(), inv);
+                hist.addInvocation(inv);
             });
         }