You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by imhotep <gi...@git.apache.org> on 2016/09/16 22:44:21 UTC
[GitHub] cordova-lib pull request #490: Android studio
GitHub user imhotep opened a pull request:
https://github.com/apache/cordova-lib/pull/490
Android studio
Adds Android Studio support
Adds some logging for when patformApi fails for weird reasons.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/imhotep/cordova-lib android_studio
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #490
----
commit 6c622f51ace9a2a0bab73c5ec910e81f835199ba
Author: Joe Bowser <bo...@apache.org>
Date: 2016-02-12T22:06:42Z
CB-8320: We look for a build.gradle to make sure it's Android, not an AndroidManifest, because it moved
commit 062f15f52469dd438ee2831c12e28434589fc759
Author: Joe Bowser <bo...@apache.org>
Date: 2016-07-28T19:42:47Z
CB-8320: Lint
commit a25ddc260bbbf2aef254fb6cf91436d6edfd3ea3
Author: Anis Kadri <an...@apache.org>
Date: 2016-08-29T14:28:55Z
config.xml has a different location in Android Studio
commit 99931eb03cc440e5fb5d7721abb92aa4938fe30e
Author: Anis Kadri <an...@apache.org>
Date: 2016-08-29T14:29:24Z
Adding error message to help debug platformApi loading errors
commit 6a6821ff645490aac5f616fdf468a528ac92464d
Author: Anis Kadri <an...@apache.org>
Date: 2016-09-15T00:04:23Z
undoing android_parser changes
commit 51355f71ca5ff54e727df13a5ab468c4988c0e2b
Author: Anis Kadri <an...@apache.org>
Date: 2016-09-16T22:35:41Z
Unifying quotes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #490: Android studio
Posted by imhotep <gi...@git.apache.org>.
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/490#discussion_r80154885
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -60,6 +60,8 @@ function getPlatformApi(platform, platformRootDir) {
events.emit('warn', ' Using this version of Cordova with older version of cordova-' + platform +
' is being deprecated. Consider upgrading to cordova-' + platform + '@' +
platforms[platform].apiCompatibleSince + ' or newer.');
+ } else {
+ events.emit('warn', 'Error loading cordova-'+platform);
--- End diff --
Not a lot. However, whenever there is something wrong with the `PlatformApi`, the error that gets displayed to the user is indicating that they have the wrong version of the platform. In reality though, something could be wrong with the `PlatformApi` code which can be **super** misleading, hence the change. This is a very small change that can help immensely with debugging and troubleshooting errors related to `PlatformApi` code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #490: Android studio
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/490#discussion_r79263894
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -193,6 +193,11 @@ function resolveConfigFilePath(project_dir, platform, file) {
return filepath;
}
+ // FIXME android studio
+ if(platform === 'android' && !fs.existsSync(filepath)) {
--- End diff --
Can you put a comment here to describe how this works and why it is needed.
It looks to me like if we are looking for config.xml and platform is android, the `return filepath;` call on ln:193 is going to return before ever getting here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #490: Android studio
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/490#discussion_r80110771
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -60,6 +60,8 @@ function getPlatformApi(platform, platformRootDir) {
events.emit('warn', ' Using this version of Cordova with older version of cordova-' + platform +
' is being deprecated. Consider upgrading to cordova-' + platform + '@' +
platforms[platform].apiCompatibleSince + ' or newer.');
+ } else {
+ events.emit('warn', 'Error loading cordova-'+platform);
--- End diff --
Does this error get shown often?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #490: Android studio
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #490: Android studio
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/490
## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/490?src=pr) is 80.38% (diff: 100%)
> Merging [#490](https://codecov.io/gh/apache/cordova-lib/pull/490?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will increase coverage by **<.01%**
```diff
@@ master #490 diff @@
==========================================
Files 67 67
Lines 5183 5184 +1
Methods 835 835
Messages 0 0
Branches 1005 1005
==========================================
+ Hits 4166 4167 +1
Misses 1017 1017
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [f8b58c7...51355f7](https://codecov.io/gh/apache/cordova-lib/compare/f8b58c782c71558516adbbd81929ee31ec3ded7f...51355f71ca5ff54e727df13a5ab468c4988c0e2b?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org