[GitHub] [spark] adrian-ionescu commented on a change in pull request #24175: [SPARK-27232][SQL]Ignore file locality in InMemoryFileIndex if spark.locality.wait is set to zero

[GitBox <gi...@apache.org>]

adrian-ionescu commented on a change in pull request #24175: [SPARK-27232][SQL]Ignore file locality in InMemoryFileIndex if spark.locality.wait is set to zero
URL: https://github.com/apache/spark/pull/24175#discussion_r269083794
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
 ##########
 @@ -168,10 +168,12 @@ object InMemoryFileIndex extends Logging {
       filter: PathFilter,
       sparkSession: SparkSession): Seq[(Path, Seq[FileStatus])] = {
 
+    val ignoreFileLocality = sparkSession.sparkContext.conf.get[Long](config.LOCALITY_WAIT) == 0L
 
 Review comment:
   I think it'd be safer to check the more specific confs as well and only perform this optimization if they're all 0.
   https://github.com/apache/spark/blob/e4b36df2c0ae3bdba4484f9f92461dbb528d8fb9/core/src/main/scala/org/apache/spark/internal/config/package.scala#L1160-L1167
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org