You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/09/11 20:28:28 UTC

[GitHub] [camel-k] claudio4j commented on a diff in pull request #4729: feat: knative service trait annotation support

claudio4j commented on code in PR #4729:
URL: https://github.com/apache/camel-k/pull/4729#discussion_r1322041065


##########
pkg/trait/knative_service_test.go:
##########
@@ -19,8 +19,10 @@ package trait
 
 import (
 	"path/filepath"
+	"reflect"
 	"testing"
 
+	routev1 "github.com/openshift/api/route/v1"

Review Comment:
   Is it correct to use the openshift route object to test the knative service annotation ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org