You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Charles Chen <ch...@fb.com> on 2011/07/08 23:36:47 UTC

Review Request: HIVE-1219: CREATE TABLE LIKE view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

Review request for hive.


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1144394 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1144394 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1144394 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1057/diff


Testing
-------

Seems to work


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/#review1096
-----------------------------------------------------------


r9 passes unit tests

- Charles


On 2011-07-16 22:51:22, Charles Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1057/
> -----------------------------------------------------------
> 
> (Updated 2011-07-16 22:51:22)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> This addresses bug HIVE-1218.
>     https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1057/diff
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Charles
> 
>

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-16 22:51:22.078393)


Review request for hive.


Changes
-------

Regenerated unit tests that had EXTERNAL : FALSE


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1057/diff


Testing
-------

Unit tests passed


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-15 23:23:25.099707)


Review request for hive.


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1057/diff


Testing
-------

Unit tests passed


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-15 21:23:11.221099)


Review request for hive.


Changes
-------

Remove "EXTERNAL" parameter for not-external tables, reset owner and creation time.


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1057/diff


Testing
-------

Unit tests passed


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-14 22:11:41.745504)


Review request for hive.


Changes
-------

whoops dropped create_like_view.q


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 

Diff: https://reviews.apache.org/r/1057/diff


Testing
-------

Unit tests passed


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-14 21:28:29.944878)


Review request for hive.


Changes
-------

Fix CREATE EXTERNAL TABLE LIKE table


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 

Diff: https://reviews.apache.org/r/1057/diff


Testing
-------

Unit tests passed


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by John Sichi <js...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/#review1062
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q
<https://reviews.apache.org/r/1057/#comment2134>

    Why are you doing DESCRIBE FORMATTED twice for these tables?



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out
<https://reviews.apache.org/r/1057/#comment2135>

    Shouldn't this be EXTERNAL_TABLE?


- John


On 2011-07-14 18:54:32, Charles Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1057/
> -----------------------------------------------------------
> 
> (Updated 2011-07-14 18:54:32)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> This addresses bug HIVE-1218.
>     https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1057/diff
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Charles
> 
>

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-14 18:54:32.868981)


Review request for hive.


Changes
-------

Fixed dropped unit test


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146841 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146841 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146841 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146841 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146841 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1057/diff


Testing
-------

Unit tests passed


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-13 23:34:26.247370)


Review request for hive.


Changes
-------

Unit tests passed


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1145801 

Diff: https://reviews.apache.org/r/1057/diff


Testing (updated)
-------

Unit tests passed


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-12 23:17:38.731527)


Review request for hive.


Changes
-------

Fixed changes in comments


Summary
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1145801 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1145801 

Diff: https://reviews.apache.org/r/1057/diff


Testing (updated)
-------

Running tests


Thanks,

Charles

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by John Sichi <js...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/#review1039
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/1057/#comment2112>

    indentation?



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
<https://reviews.apache.org/r/1057/#comment2115>

    Can you include a testcase for a partitioned view?  I don't see a codepath for that (we agreed the new table should come out with the same partition columns as the view).
    
    Also add a testcase for create externa table like base_table since you fixed a bug in that existing codepath.  You can put that in create_like.q since it doesn't have anything to do with views.



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
<https://reviews.apache.org/r/1057/#comment2116>

    Add order by on these queries for determinism.


- John


On 2011-07-11 22:06:40, Charles Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1057/
> -----------------------------------------------------------
> 
> (Updated 2011-07-11 22:06:40)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> This addresses bug HIVE-1218.
>     https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145292 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1145292 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145292 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145292 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1057/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>

Re: Review Request: HIVE-1218: CREATE TABLE LIKE view

Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/
-----------------------------------------------------------

(Updated 2011-07-11 22:06:40.671325)


Review request for hive.


Summary (updated)
-------

https://issues.apache.org/jira/browse/HIVE-1218


This addresses bug HIVE-1218.
    https://issues.apache.org/jira/browse/HIVE-1218


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145292 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1145292 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145292 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145292 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1057/diff


Testing (updated)
-------


Thanks,

Charles