[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5588: Mshost stats

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5588:
URL: https://github.com/apache/cloudstack/pull/5588#discussion_r759965660



##########
File path: ui/src/config/section/infra.js
##########
@@ -60,11 +62,12 @@ export default {
       component: () => import('@/views/infra/CpuSockets.vue')
     },
     {
-      name: 'managementserver',
-      title: 'label.management.servers',
-      icon: 'rocket',
-      permission: ['listManagementServers'],
-      columns: ['name', 'state', 'version']
+      name: 'metric',
+      title: 'label.metrics',
+      icon: 'bar-chart',
+      docHelp: 'adminguide/management.html#metrics',
+      permission: ['listDbMetrics', 'listUsageServerMetrics'],
+      component: () => import('@/components/view/Metrics.vue')

Review comment:
       should be moved to `./views/infra/Metrics.vue` ths component is not generic enough to warrant this location.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org