You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by cestella <gi...@git.apache.org> on 2018/06/14 16:02:17 UTC
[GitHub] metron pull request #1062: Make threat triage score function with dots as we...
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/1062
Make threat triage score function with dots as well as colons
## Contributor Comments
This is the UI portion of #1055 . The test script for #1055 should be used with the following modifications:
* As part of step 3, edit the template at /var/lib/ambari-agent/cache/common-services/METRON/0.5.0/package/files/metaalert_index.template by changing source:type to source.type
Please ensure that you drive this via the UI. Specifically look for threat scores that show up in the alerts UI both when you do a basic search for snort data as well as after creating meta alert.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron threat_triage_score_dots
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1062.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1062
----
commit fd8ac2a8601596814a2577b16615a18fd249660c
Author: cstella <ce...@...>
Date: 2018-06-14T15:48:40Z
Make threat triage score function with dots as well as colons
----
---
[GitHub] metron pull request #1062: METRON-1617: Make threat triage score function wi...
Posted by cestella <gi...@git.apache.org>.
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/1062
METRON-1617: Make threat triage score function with dots as well as colons
## Contributor Comments
This is the UI portion of #1055 . The test script for #1055 should be used with the following modifications:
* As part of step 3, edit the template at /var/lib/ambari-agent/cache/common-services/METRON/0.5.0/package/files/metaalert_index.template by changing source:type to source.type
Please ensure that you drive this via the UI. Specifically look for threat scores that show up in the alerts UI both when you do a basic search for snort data as well as after creating meta alert.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron threat_triage_score_dots
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1062.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1062
----
commit fd8ac2a8601596814a2577b16615a18fd249660c
Author: cstella <ce...@...>
Date: 2018-06-14T15:48:40Z
Make threat triage score function with dots as well as colons
commit d92a9515af178ab4302ed71a8666291e57d8f813
Author: cstella <ce...@...>
Date: 2018-06-14T16:08:15Z
Merge branch 'master' into threat_triage_score_dots
commit 28844f9bb54716b088d8a063c3d57d75e94bedb2
Author: cstella <ce...@...>
Date: 2018-06-14T16:15:53Z
bad cherry-pick..sorry.
commit 5b470a633e432b1983da4771c4929f4fb92ba350
Author: cstella <ce...@...>
Date: 2018-06-15T19:28:00Z
Standardizing on some naming across ts files and fixing bugs
----
---
[GitHub] metron issue #1062: METRON-1617: Make threat triage score function with dots...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1062
Found 1 small bug. The changes you made to table-view.component.html also need to be applied to tree-view.component.html. You can test by selecting 2 groups and expanding one of the top level groups. The alerts listed in the tree view should have scores instead of '-'. I personally like what you did with the getScore method in meta-alerts.component.html. Would it make sense to keep it consistent across the various components?
---
[GitHub] metron issue #1062: METRON-1617: Make threat triage score function with dots...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1062
I tested this again in full dev after the recent changes and it's working. Looks good to me. Probably need to bounce this PR to get past the intermittent travis error but +1 pending that.
---
[GitHub] metron pull request #1062: METRON-1617: Make threat triage score function wi...
Posted by cestella <gi...@git.apache.org>.
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/1062
---
[GitHub] metron pull request #1062: METRON-1617: Make threat triage score function wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1062
---
[GitHub] metron issue #1062: METRON-1617: Make threat triage score function with dots...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1062
@merrimanr thanks for the review. I fixed the bug and standardized on a getScore() across the ts files
---
[GitHub] metron issue #1062: METRON-1617: Make threat triage score function with dots...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1062
Bouncing
---